Closed (fixed)
Project:
Coder
Version:
5.x-2.7
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Apr 2008 at 17:45 UTC
Updated:
27 May 2008 at 16:23 UTC
Jump to comment: Most recent file
$range = max(.01, $max - $min) * 1.0001;
The preceding code from Tagadelic gets flagged with:
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | coder_241886.patch | 1.38 KB | stella |
Comments
Comment #1
stella commentedCoder already had code to handle false warnings of invalid string concatenation for decimal points, however it wasn't handling these two cases:
$a = (.01);or$a = (1.)- i.e. where there is opening parentheses following by a dot, or a dot followed by a closing parentheses . The attached patch fixes this. However I think it's a bad practise to use of these, especially the latter. I would prefer0.01and1.0(or just1). Perhaps we should add a check for this? I don't know if Drupal has such a coding standard.Cheers,
Stella
Comment #2
stella commentedCommitted.
Comment #3
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.