Hello,

Are there any plans to work on an update of this module for Drupal 6? We have just started looking into the patches and can post them here. Should patches be made against 5.x-1.x-dev or CVS HEAD?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

robertDouglass’s picture

Make patches against DRUPAL-5. When we start developing a 6 branch we'll first move changes into HEAD, and eventually tag it DRUPAL-6. Thanks for working on this.

pmcg’s picture

Status: Active » Needs review
FileSize
5.82 KB

Heres an updated paths patch. I didn't patch against the patch so this is, sort of, a drop-in replacement.
Unfortunately I have some other things on my plate and I won't be working on this in foreseeable future. I thought I should submit what i've worked on thus far though.

robertDouglass’s picture

Status: Needs review » Closed (won't fix)

The paths patch in the DRUPAL-5 doesn't work well and I'm not porting it in its current state.

Flying Drupalist’s picture

Hello, I would also love to see a 6.x version. Thanks

Murz’s picture

subscribe

Richard Blackborder’s picture

Me too. Is there anything I can do to help it become a reality?

mikejoconnor’s picture

Title: Upgrade to Drupal 6 » Upgrade node, comment, and taxonomy to Drupal 6
Status: Closed (won't fix) » Needs review
FileSize
5.65 KB

Hello,

I'm uploading my first attempt at converting the advcache module to D6. In the .zip file attached you will find advcache_d6.patch for upgrading the advcache module, as well as patches for node, comment, and taxonomy.

I'm sure we can find some improvements. This is simply a port of the d5 version to d6.

mikejoconnor’s picture

FileSize
6.8 KB

Line 54 of the taxonomy patch used cache_set incorrectly.

+    cache_set('tree::'. $vid, 'cache_taxonomy', $tree);

changed to

+    cache_set('tree::'. $vid, $tree, 'cache_taxonomy');
mikejoconnor’s picture

Status: Needs review » Needs work

This seems to be automatically save nodes as not published. It could be something else in my config. does anyone else experience this?

mikejoconnor’s picture

Status: Needs work » Needs review

false alarm. Faulty triggers/actions config

dropchew’s picture

subscribing, been using memcache and luv to combine this!

joshk’s picture

Mike O'connor's .zip applies cleanly against D6.9. Will be testing this out as per:

http://groups.drupal.org/node/19385

joshk’s picture

Well, path caching doesn't seem to be working yet -- nothing ever calls drupal_lookup_path() with $action == 'cache' -- but node, comment and taxonomy caching definitely do.

I would also like to see user_load() get a cache here.

More soon.

joshk’s picture

FileSize
6.87 KB

Ok. The lack of path caching is due to no call to drupal_lookup_path('cache');.

Previously it was suggested this could be done w/a patch to common.inc. Implementing hook_exit() might be a bit cleaner.

Doing that currently doesn't allow expiration to be set correctly and causes a notice error. The attached patches adds working support and resolves another notice-level error from the patch to taxonomy.module.

mikejoconnor’s picture

FileSize
10.7 KB

I resolved an issue in the taxonomy patch due to an unserialize I failed to remove in the first patch.

I've been using this on a dev site for the last couple months, and it seems to be working. I would suggest we create a D6 development version in CVS. This will get more exposure, and allow us to work on the individual issues individually instead of passing around a zip.

Thoughts?

joshk’s picture

Status: Needs review » Reviewed & tested by the community

I'm in agreement. The current group of patches (thanks for that taxonomy fix) makes a worthy D6-dev branch. Getting that into the project system to allow others to test deploying it would be a great next step.

If we get this up and running I will put it into use on a number of projects going into development immediately (as well as my personal blog, natch) which will give us a wider base for testing and improvement over the next few months.

Also, as Robert mentioned on the other thread, the time is now to start thinking about D7. Generalized object caching is going to be critical for massively scalable drupal applications, and really doing it "right" means having the support in core.

robertDouglass’s picture

Mike - take the lead. Create the DRUPAL-6--1 branch/tag.

joshk’s picture

Any update here?

EvanDonovan’s picture

I tried applying the node, comment, and taxonomy patches to a Drupal 6.10 installation. (I didn't apply the path patch since Robert Douglass said it had issues.) When I tried applying them, I received an error for the node and taxonomy patches saying "Reversed (or previously applied) patch detected!" Does anyone know why this might be?

Flying Drupalist’s picture

Perhaps path patch should utilize this? :
http://drupal.org/node/223075

dkruglyak’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Reviewed & tested by the community » Needs work

The latest 6.x-1.x-dev patches fail with 6.11 for node and taxonomy. Need to be re-rolled.

Vacilando’s picture

Subscribing

ThomasH’s picture

FileSize
1.98 KB

Node patch proposal for d6.13

ThomasH’s picture

FileSize
4.45 KB

Taxonomy patch proposal for d6.13

dkruglyak’s picture

@ThomasH: How extensively are these patches tested?

ThomasH’s picture

It has gone through basic testing here. We're now testing it some more to assure everything is working properly. But I figured, the more eyes on the patch, the more chance of finding bugs.

fortis’s picture

i have warnings with 6.13-patches:

* user warning: Table 'cache_taxonomy' doesn't exist query: cache_get /* admin : cache_get */ SELECT data, created, headers, expire, serialized FROM cache_taxonomy WHERE cid = 'term::703' in /home/cookdanc/public_html/includes/cache.inc on line 26.

* user warning: Table 'cache_taxonomy' doesn't exist query: cache_set /* admin : cache_set */ UPDATE cache_taxonomy SET data = 'O:8:\"stdClass\":5:{s:3:\"tid\";s:3:\"703\";s:3:\"vid\";s:1:\"2\";s:4:\"name\";s:33:\"Крепежные изделия\";s:11:\"description\";s:0:\"\";s:6:\"weight\";s:1:\"0\";}', created = 1261050995, expire = 0, headers = '', serialized = 1 WHERE cid = 'term::703' in /home/cookdanc/public_html/includes/cache.inc on line 109.

crea’s picture

Subscribing. I'm too testing patch in #23

ruphus’s picture

Subscribing.