Upgrade node, comment, and taxonomy to Drupal 6

Make patches against DRUPAL-5. When we start developing a 6 branch we'll first move changes into HEAD, and eventually tag it DRUPAL-6. Thanks for working on this.

Heres an updated paths patch. I didn't patch against the patch so this is, sort of, a drop-in replacement.
Unfortunately I have some other things on my plate and I won't be working on this in foreseeable future. I thought I should submit what i've worked on thus far though.

The paths patch in the DRUPAL-5 doesn't work well and I'm not porting it in its current state.

Hello, I would also love to see a 6.x version. Thanks

subscribe

Me too. Is there anything I can do to help it become a reality?

Hello,

I'm uploading my first attempt at converting the advcache module to D6. In the .zip file attached you will find advcache_d6.patch for upgrading the advcache module, as well as patches for node, comment, and taxonomy.

I'm sure we can find some improvements. This is simply a port of the d5 version to d6.

Line 54 of the taxonomy patch used cache_set incorrectly.

This seems to be automatically save nodes as not published. It could be something else in my config. does anyone else experience this?

false alarm. Faulty triggers/actions config

subscribing, been using memcache and luv to combine this!

Mike O'connor's .zip applies cleanly against D6.9. Will be testing this out as per:

http://groups.drupal.org/node/19385

Well, path caching doesn't seem to be working yet -- nothing ever calls drupal_lookup_path() with $action == 'cache' -- but node, comment and taxonomy caching definitely do.

I would also like to see user_load() get a cache here.

More soon.

Ok. The lack of path caching is due to no call to drupal_lookup_path('cache');.

Previously it was suggested this could be done w/a patch to common.inc. Implementing hook_exit() might be a bit cleaner.

Doing that currently doesn't allow expiration to be set correctly and causes a notice error. The attached patches adds working support and resolves another notice-level error from the patch to taxonomy.module.

I resolved an issue in the taxonomy patch due to an unserialize I failed to remove in the first patch.

I've been using this on a dev site for the last couple months, and it seems to be working. I would suggest we create a D6 development version in CVS. This will get more exposure, and allow us to work on the individual issues individually instead of passing around a zip.

Thoughts?

I'm in agreement. The current group of patches (thanks for that taxonomy fix) makes a worthy D6-dev branch. Getting that into the project system to allow others to test deploying it would be a great next step.

If we get this up and running I will put it into use on a number of projects going into development immediately (as well as my personal blog, natch) which will give us a wider base for testing and improvement over the next few months.

Also, as Robert mentioned on the other thread, the time is now to start thinking about D7. Generalized object caching is going to be critical for massively scalable drupal applications, and really doing it "right" means having the support in core.

Mike - take the lead. Create the DRUPAL-6--1 branch/tag.

Any update here?

I tried applying the node, comment, and taxonomy patches to a Drupal 6.10 installation. (I didn't apply the path patch since Robert Douglass said it had issues.) When I tried applying them, I received an error for the node and taxonomy patches saying "Reversed (or previously applied) patch detected!" Does anyone know why this might be?

Perhaps path patch should utilize this? :
http://drupal.org/node/223075

The latest 6.x-1.x-dev patches fail with 6.11 for node and taxonomy. Need to be re-rolled.

Subscribing

Node patch proposal for d6.13

Taxonomy patch proposal for d6.13

@ThomasH: How extensively are these patches tested?

It has gone through basic testing here. We're now testing it some more to assure everything is working properly. But I figured, the more eyes on the patch, the more chance of finding bugs.