Drupal 6?

As usual, the answer is when one of the following happens:

- Someone submits a working and tested patch.
- We need it for a client site.
- A clients funds the development.
- We have free time to do it (unlikely).

Fair enough. thanks for the response.

Hellon
Here is a first attempt 5 to 6 patch that applies to 1.0 version.
I was not able to make it work on node create, but it works a treat on node update, so any help is welcome.
Here is the link: watermark_5to6.patch.

Regards,
David

As I just realize there's a more recent dev version, going to make a patch for it. :)

Edit: OK, I think I spotted a part of my problem: in Drupal 6, validate operation seems to occur to early in node creation. Thus, image data is not filled in $node object...
Need to find a better hook than nodeapi.

Edit2: here is a link to the same patch applying to 5.x-dev version of watermark module: watermark_5to6_dev.patch.

The problem is the same as stated before: when creating image node, the watermark is not applied, as the "validate" operation of "hook_nodeapi" occurs before image module fills $node (thus, $node->new_file and $node->images are empty...).
I thought of using hook_image_alter, but this would imply that watermark is applied to original file, before resizing (then all images will get the watermark), so this is not a good solution.

Regards,
David

The patch does not apply.

Please create the patch against a check out from CVS with the tag DRUPAL-5.

See http://drupal.org/patch for details.

Also, attach patches here rather than to some remote site.

I did not attach patch because I have not been able to attach files to my Drupal posts for a while (don't know why...).
The patches I provided apply to: 1.0 for the first, and 1.x-dev (the one available on the project page) for the second.
I don't know how to check out CVS repository, could you tell me please?

Thanks,
David

I forgot to say: to create the patch, I used "diff -Naurp watermark.old watermark", where watermark.old is directory of the version I started with (1.0 or 1.x-dev as I said before), and watermark is the directory I developped in.

The dev patch does not apply.

patching file watermark.module
Hunk #2 FAILED at 140.
Hunk #3 succeeded at 174 (offset 5 lines).
Hunk #4 succeeded at 255 with fuzz 1 (offset 5 lines).
Hunk #5 FAILED at 285.
Hunk #6 succeeded at 501 (offset 5 lines).
2 out of 6 hunks FAILED -- saving rejects to file watermark.module.rej

This is how you checkout from the cvs repository. http://drupal.org/node/321

Then you use cvs diff, as per here http://drupal.org/patch/create

Do you try to apply it to 1.x-dev (the one I can download from project page), or do you still try on HEAD, which will never work, I know? :)

David

Why is HEAD older than DRUPAL-5 tag?

Why are you confusing yourself?

I said use the DRUPAL-5 tag. Which was updated 5 weeks (for .module) and 2 weeks (for .info).

Why are you asking about HEAD?

Please follow the instructions I gave you.

Here it is, sorry the confusion.
I was not able to make a patch that renames po/ folder to translations/, so this patch only patchs .module and .info files. :)
PS: I seem to be able to attach file again. :)

The problem I had is still here: watermark is not applied on image creation, but it is well applied on image edition. :-\

Thank you.

The Drupal 6 dev version will appear here in 24 hours.

http://drupal.org/node/274032

As I said, it is not completely OK. :)

Any help?

subscribing

subscribing

Will there be an official 6x dev release?

Yes. As soon as enough people test the -dev version and find it working well.

There are a few issues in the queue that says otherwise, so this will not happen spontaneously nor in a short time.

any new news? thanks

waiting for news too.
Is this module working now in drupal 6? or is there any similar module working?
Thanks.

subscribing

subscribing

subscribing

Is this project dead?

It is not dead. If there are tested patches I will apply it.

Is this currently working for Drupal 6? I downloaded the dev version and tried using with no luck