Version for Drupal 5.x

ardee - April 3, 2008 - 23:10
Project:Ext
Version:6.x-1.x-dev
Component:Miscellaneous
Category:feature request
Priority:normal
Assigned:ximo
Status:closed
Description

Would this be straightforward to port to Drupal 5.7?

#1

ximo - May 23, 2008 - 14:01
Status:active» active (needs more info)

Probably very straight forward, yes. If there's still a need for this, let me know, and I'll look into it.

(Sorry for the wait, for some reason I wasn't monitoring the issue queue any more..)

#2

ximo - May 23, 2008 - 14:03
Assigned to:Anonymous» ximo
Status:active (needs more info)» active

And wouldn't you know it.. I just noticed another issue asking for a 5.x version. I'll look into it right away!

#3

Kiam@avpnet.org - May 23, 2008 - 15:09

I was working on a module for Drupal 5.x that used the Ext JS 2.1 or higher.
Would the skeleton code I wrote be of any help?

#4

ximo - May 24, 2008 - 16:01
Status:active» fixed

Done. If you have any interesting code, I wouldn't mind having a look at your code :)

Download here (once the packaging script spits out a tarball):
http://drupal.org/node/262278

#5

Kiam@avpnet.org - May 24, 2008 - 21:47

I actually don't have access to that node, so I don't know what actually it is. :-)

#6

ximo - May 25, 2008 - 22:48

Hm, strange. Can you see it now? If not, here's the 5.x development snapshot tarball: http://ftp.drupal.org/files/projects/ext-5.x-1.x-dev.tar.gz

#7

Kiam@avpnet.org - May 26, 2008 - 15:06

I can now see it.

I have some observations.

  • In the settings code, the module presents to the administrator a list of all the JavaScript files found in the Ext JS library folder, which would be ext-all-debug.js, ext-all.js, ext-core.js, ext-core-debug.js; considering that the module should be made for any developers whom create modules based on Ext JS, would not be better to make that a choice between the debug version of the library, and the plain version?
  • The ext_load_library() function uses a parameter that causes the function to load the Ext JS or nothing; what would the use of that parameter be?

#8

ximo - May 27, 2008 - 08:30

1. I thought that as users may build their own Ext library on http://extjs.com/products/extjs/build/ and name it anything, it would be best to list all .js files in the root directory of Ext. All those files are library files anyway. If we get dynamic loading of Ext components going, there wouldn't be a need for this, as the ext-core.js and ext-core-debug.js would be the only useful files :)

2. It allows modules to load any library file, and defaults to the user selected one. This is very simply done, but it works for now..

Thanks for your feedback!

Btw, the changes are based on the D6 branch, which is also updated.

#9

Anonymous (not verified) - June 10, 2008 - 08:33
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.