Hello, first, thanks for the module!

It didn't work out of the box though. I noticed that drupal_mail_wrapper() parameters are incorrectly place $headers parameter as the 5th param, while it's the 6th. 5th is $from.

Then, the most important part as well. -f is not only for Return-Path. It's also for MAIL FROM in the SMTP transcript. So its use isn't only with Return-Path. It's generally a good practice. And so I expected that the module would use -f automatically for me and set Return-Path accordingly.

Please review attached a patch which tries to fix these issues.

Thanks,

CommentFileSizeAuthor
returnpath_auto.patch2.24 KBAmrMostafa

Comments

toemaz’s picture

toemaz commented
Priority: Normal » Critical

Tested and confirmed it is working well (on a production website).
Thx for the patch.

I move this up to 'critical' since the current 5.x-1.1 release is just not working out of the box. A shame because such a small but crucial module should be running smoothly.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

This patch didn't work on my site, I had to change the following line:

    if (strcasecmp('return-path', $name)) {

To:

    if (drupal_strtolower($name) == 'return-path') {

As it was returning TRUE from mime-type.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Fixed

Changes made in latest 5.x-1.x-dev.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.