Output of ad links (duplicate REL attribute) and ad_image images (missing ALT attribute) is XHTML-invalid. Attached patch fixes both issues.

Regarding REL attribute: ad.js seems to have been removed in current development snapshot. However, the TARGET attribute is deprecated and not XHTML-valid. I have rewritten the original code to work without a separate JavaScript by using an onclick-handler.

CommentFileSizeAuthor
ad-DRUPAL-5.xhtml_.patch2.44 KBsun

Comments

jeremy’s picture

jeremy commented
Assigned: sun » jeremy

To review and hopefully commit before next release.

jeremy’s picture

jeremy commented
Status: Needs review » Postponed (maintainer needs more info)

Are you saying that the only XHTML-valid way to set the target is using JavaScript? Is there any other way?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Postponed (maintainer needs more info) » Needs review

Yes, all other ways are either CSS3-based (not yet supported by almost any browser) or DTD-based (a themer's decision).

See http://www.google.com/search?q=xhtml+target&hl=en for further information.

jeremy’s picture

jeremy commented

I have mixed emotions, but I suppose there's not a lot of choice. I'll revisit this.

I did commit the fix for the missing alt tag (and a couple other missing alt tags in the same module).

waddles’s picture

waddles commented

adserve.inc also spits out duplicate html id attributes when you use javascript. It won't bork the validators but it does cause problems for anyone trying to use jquery css id selectors.

jeremy’s picture

jeremy commented
Status: Needs review » Fixed

This was committed some time back. Updating issue status.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.