Hi,

Just tried installing your module on a clean install of Drupal 6.1 and when I access the admin section the various links do not work. It seems in the href attribute it is only putting the root directory in their and not the full path.

[code]

Feed aggregator

[/code]

Only modules enabled so far are
-forums
-clean urls
-pathauto

CommentFileSizeAuthor
#10 iconify.module.zip1.74 KBAnonymous (not verified)

Comments

ajevans85’s picture

ajevans85 commented

Well it was a quick fix, should of held of posting.

Anyway, line 85 needs changing to

$output .= '<dt>'. l($item['title'], $item['link_path']) .'</dt>';

As the $item['path'] variable in the original code below doesn't seem to be se

$output .= '<dt>'. l($item['title'], $item['path']) .'</dt>';
tomaszx’s picture

tomaszx commented

i confirm this bug. It's very simple to fix. Please quick this issue.

xaverx’s picture

xaverx commented

I use above fix, almost all working beside: admin/build/menu and when I use function "Hide descriptions" in admin menu link are broken.

Macronomicus’s picture

Macronomicus commented

I can confirm that ... works now save for when descriptions are hidden on the /admin page.

lennyaspen’s picture

lennyaspen commented

yes it works

czarphanguye’s picture

czarphanguye commented

@ajevans85, Thanks. that did the trick.

Macronomicus’s picture

Macronomicus commented

I can confirm that admin/build/menu/ still doesnt work even after this fix.
Strange .. I guess we'll have to dig some more to figure out whats doing it. I dont see another similar code issue like the fix above.

Jezze’s picture

Jezze commented

You have to use $item['href'] instead of $item['link_path'].

Change line 75 (with description) and line 86 (without description).

Macronomicus’s picture

Macronomicus commented

I can confirm that fixes all the links now.

Thanks for the tip with that ... I do like this handy module ... spiffs things up easy and simply.

Cheers!

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new iconify.module.zip1.74 KB

hey the 'href' code fix works!

I changed line 75 and 86 as directed above.

I am attaching the corrected iconify.module file, which of course goes in the main iconify module directory.

Cheers!

madamep

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Any chance of having this committed to CVS? It is kind of an important fix? Thanks. :)