Block layout confusing, title link broken [#242844]

I have the latest dev version of Share, and the latest versions of service links and forward. I have CSS caching turned off and I've cleared the Drupal cache. I'm testing this on Firefox Mac.

I actually couldn't get the Share link to show up at all in $links -- ShareThis worked fine, but Share just wouldn't appear -- but that was OK because I really wanted the block anyway. But the block appearance and UI is really kind of confusing.

Attached is a picture as it appears on my site. Here are my questions:

1. What is that big "Share" link at the top for? It doesn't seem to do anything (it seems to be a link to http://share/607, 607 being the nid of the node) and isn't respecting the text I inserted in "Link name" on the share settings page. I'm guessing that latter part is because that is only for the link that appears in $links, which is fine, but I still don't get why there's then this additional title inserted into the block (which has its own title). Is it supposed to go to /share/[nid]? If so, that could be useful, but it still seems a little large -- it's bigger than my block's title. I know I can change the CSS, but it doesn't seem more important than the tabs below it -- why not make it one of those?

2. Speaking of which, why are the "tabs" so close together without any padding or borders? That makes it really hard to read.

3. In the link codes, the first item is described as "Direct Url" -- it really should be "Direct URL" or, perhaps more helpfully, "Direct Web Address" since not everyone will know what a URL is. But there's no such thing as an url.

Overall I think this module and port is fantastic and I'm excited to use it, the block just seems a little rough around the edges. Thanks for all your hard work on this.

Comment	File	Size	Author
	Screen capture of block	21.96 KB	rootwork

Comments

Comment #1

greenskin commented 5 April 2008 at 00:09

The block was sorta last minute, it was requested by the organization I work for. Its css can be overridden as well as the regular link's css using the following function:

<?php
function theme_share_css($block = FALSE) {
  if (!$block) {
    drupal_add_css(drupal_get_path('module', 'share'). '/share.css', 'theme', 'screen');
  } else {
    drupal_add_css(drupal_get_path('module', 'share'). '/share_block.css', 'theme', 'screen');
  }
}
?>

You can add your own css file for the block by changing the second drupal_add_css().

Here is the website the block was originally designed for: http://www.itiswritten.com/betterway

There is a lot of changes/additions I have in mind for Share 2.0 and all the input you can give is very helpful especially concerning the Share block.