I briefly checked and about 95% of the test code is duplication and from getInfo it can be seen it was written with copypaste.

CommentFileSizeAuthor
#8 profile.test9.34 KBboombatower
#4 profile_tistur.test9.25 KBTistur
#2 profile_tistur.test9.5 KBTistur

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower

I will be working on this, just to let everyone know.

Tistur’s picture

Tistur commented
Status: Active » Needs work
StatusFileSize
new profile_tistur.test9.5 KB

I spoke with chx on IRC and here is the result. I have "fixed" most of the code. The exception is mostly ProfileTest2TestCase, which I cleaned up a little bit, but otherwise am stuck on.

Tistur’s picture

Tistur commented
Status: Needs work » Needs review
Tistur’s picture

Tistur commented
StatusFileSize
new profile_tistur.test9.25 KB

Some small changes. Got rid of module_list() in getInfo functions, and some style fixes.

chx’s picture

chx commented

I told Tistur to feel free to upload the whole test, there is hardly any point in bothering with a patch at this point... very nice job, I hope I will have time to test later.

boombatower’s picture

boombatower commented

@Tistur: I will review later...feel free to set this assigned to you.

Tistur’s picture

Tistur commented
Assigned: boombatower » Tistur
boombatower’s picture

boombatower commented
Status: Needs review » Needs work
StatusFileSize
new profile.test9.34 KB

Had to make a number of changes to make it proper PHP so I could run it. After running it I came up with the following:

399 passes, 298 fails and 539 exceptions.

This test needs a large amount of work.

Methods should all be camelCase unlike: test_simple_field.

I believe coding standards would say setUp( ) would be setUp() and similar with others.

boombatower’s picture

boombatower commented
Project: SimpleTest » Drupal core
Version: » 7.x-dev
Component: Code » tests
Assigned: Tistur » Unassigned

This could really use to be started over again. I may get around to it. Otherwise anyone else is free to it.

chx’s picture

chx commented
Status: Needs work » Fixed

The core profile test has been rewritten already.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.