Download & Extend

2 strings not in t() strings so untranslatable

Project:jRating
Version:5.x-1.0
Component:Miscellaneous
Category:bug report
Priority:minor
Assigned:Unassigned
Status:active

Issue Summary

first, in jrating.module itself, line 333, the words "vote" and "votes":

$num_votes_html = $num_votes_span . format_plural($rating['num_votes'], '1</span> vote', '@count</span> votes');

then in the rating.js file, line line 153

$div = $('<div class="cancel"><a href="#0" title="Cancel Rating">Cancel Rating</a></div>');

maybe you can't use t() strings in js files....

Comments

#1

Do you think, there is any chance to get this translatable? With the rating options you did succeed. So why not with the 'Cancel Rating'!

#2

1) The documentation for format_plural says "Since t() is called by this function, make sure not to pass already-localized strings to it.".
http://api.drupal.org/api/function/format_plural/5

2) For the javascript there's probably a way to do that with Drupal.settings - I'll look into it.