Warning: Call-time pass-by-reference has been deprecated

tom-d - April 6, 2008 - 10:41
Project:DataBase File Manager
Version:5.x-3.2
Component:Code
Category:bug report
Priority:normal
Assigned:rooey
Status:closed
Description

To my surprise after enabling this module it spits out before drupals header

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in /home/.oolong/polybonk/poly.osrcgamer.com/drupal5/sites/all/modules/dbfm/dbfm.module on line 2604

#1

tom-d - April 6, 2008 - 10:51

Changed line 2604

$ret_val = dbfm_perm_recur($fkid, &$err_str);
to

$ret_val = dbfm_perm_recur($fkid, $err_str);

#2

rooey - April 7, 2008 - 18:49

Can you confirm that this was defiantly 5.x.3.0 ?

#3

rooey - April 7, 2008 - 18:49
Assigned to:Anonymous» rooey
Status:active» postponed (maintainer needs more info)

#4

tom-d - April 9, 2008 - 00:40

Yes this was with dbfm-5.x-3.0

#5

rooey - April 14, 2008 - 23:23
Status:postponed (maintainer needs more info)» needs work

#6

cburch - April 17, 2008 - 21:20

This also happened to me with 5.x-3.1. tom-d's fix got rid of the error for me too.

#7

rooey - April 17, 2008 - 21:48
Status:needs work» needs review

Grr. I don't know how this one snuck back in on 5.x.3.1 lol - we had fixed it!

#8

gmknowles - April 22, 2008 - 23:18
Version:5.x-3.0» 5.x-3.1

The error line in the current version is now: 2576 with the expression as reference by tom-d's fix and got a mess.

ie.,

Changed line 2574

$ret_val = dbfm_perm_recur($fkid, &$err_str);
to

$ret_val = dbfm_perm_recur($fkid, $err_str);

It now appears that the error isline 1555:

$js = 'function getIconDir(){return '.drupal_to_js($base_url."/".variable_get('dbfm_icon_dir','')).';} function getDbfmPath(){return '.drupal_to_js($dbfmpath).';} function getCleanUrl(){return '.drupal_to_js($clean_url).'; }';

#9

rooey - April 24, 2008 - 21:22

Thanks will add it to the list.

#10

rooey - May 19, 2008 - 14:58
Version:5.x-3.1» 5.x-3.2-rc0

#11

rooey - June 11, 2008 - 15:01
Version:5.x-3.2-rc0» 5.x-3.2
Status:needs review» fixed

#12

Anonymous (not verified) - June 25, 2008 - 15:14
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.