Calendar ignore views' argument handling code in month view
JohnAlbin - April 6, 2008 - 13:20
| Project: | Calendar |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | JohnAlbin |
| Status: | closed |
Jump to:
Description
The argument handling code is quite powerful in views.
However, calendar’s _calendar_views_query_alter() will over-write the arguments with $_GET['q'] when using a month view.
The stated reason is to “make sure block views default to the current month”. Defaulting to the current month is a good idea, but ignoring the view’s argument handling code and forcing the current month is a bug.
| Attachment | Size |
|---|---|
| argument-handling-code.patch | 887 bytes |
#1
#2
Thanks for the patch and I apologize for not getting to it right away. I am fixing a computer melt-down that finally resulted in starting all over with a new computer and will come back and review this once I'm functional again.
If anyone else has reviewed the patch, please jump in and indicate whether it seems to work and I'll prioritize these patches first when I'm back in commission.
#3
Good catch, and you're absolutely correct. This is now fixed. Thanks!
#4
Hi is this issue fixed in the 2008-Apr-24 dev?
I just downloaded it and I still have a problem on the node view where the block mini calendar picks up the nid from node/nid as an argument therefore changing month. From what I understand this shoudn't happen and the block should default to current month.
Example
node/6 switch the block calendar to June 2008
thx
#5
gionnibgud,
Since Karen just committed the patch today, the answer to “is this issue fixed in the 2008-Apr-24 dev?” is clearly no.
-dev releases automatically get made every 12 hours if there are updates to the code in CVS. So you just need to wait a few hours.
#6
D'oh! Now I understand. Thanks for replying JohnAlbin.
#7
Automatically closed -- issue fixed for two weeks with no activity.
#8
[edit] nevermind, args are working in 6.x it's just relative args I can't figure out. will open a new issue.
Jen
#9
change back