I have fixed two out of the three. And made sure the three does not cause an infinite loop. I will figure out this one, too.

CommentFileSizeAuthor
#8 system_move_like_tables.patch3.38 KBboombatower
#7 system.test4.94 KBboombatower
#6 system.test4.68 KBboombatower
#5 system.test4.6 KBboombatower
#4 system.test4.88 KBboombatower
#3 system.test3.49 KBboombatower
#1 system_module.patch9.77 KBRok Žlender
system_tests.patch8.8 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Rok Žlender’s picture

Rok Žlender CreditAttribution: Rok Žlender commented
FileSize
system_module.patch9.77 KB

Fixed few notices.

boombatower’s picture

boombatower CreditAttribution: boombatower commented

Do we really need to just brute force turning on all the modules?

Can't we just simplify code by enabling certain cases where we know dependencies?

Just seems like a waste of processing time.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
FileSize
system.test3.49 KB

I have essentially rewritten the system test. Much of the previous code was there to ensure the the module state was as it wanted.

Since we start off with a clean database that is no longer necessary. Attempting all possibilities is, as the loops did, is somewhat of over kill and is hard to follow, not to mention slow.

Let me know what you think.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
FileSize
system.test4.88 KB

Here is a revised version which I think should do the trick.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
FileSize
system.test4.6 KB

Cleaned up.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
FileSize
system.test4.68 KB

t()ing cleanup.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
FileSize
system.test4.94 KB

Last update.

Will move assertTableCount to DrupalTestCase in patch.

boombatower’s picture

boombatower CreditAttribution: boombatower commented
FileSize
system_move_like_tables.patch3.38 KB

This is patch that moves assertTableCount code to simpletest.module..

boombatower’s picture

boombatower CreditAttribution: boombatower commented
Status: Needs review » Fixed

The system test and patch have been committed.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.