I don't know if this is a bug or not. I haven't found anybody else with this issue so maybe it's just me or my server, but it's disconcerting and if I can't figure out how to prevent it I'll have to disable the module and figure something else out (which I don't want to do because the mod works perfectly otherwise). The site in question is www.chchne.com. On every page load and refresh (other than the front page, which is a cheesy Flash anim, not mine) the logo image is redrawn and a sort of scan line runs through the image. I've got caching set to normal. Any ideas or is this normal behavior?

Thanks.

CommentFileSizeAuthor
#2 Clipboard01.jpg84.99 KBlancemonotone
#1 Capture.JPG91.12 KBpobster

Comments

pobster’s picture

pobster commented
StatusFileSize
new Capture.JPG91.12 KB

Small world! My girlfriend works for the Make-A-Wish Foundation! Can you post a jpg of the behaviour, it honestly looks fine to me using FF2.0.0.13?

Logotool doesn't alter anything to do with logos other than to display something different if that's what you've set it to do. It's likely a theme related issue and I'm sure we can get to the bottom of it.

edit: or perhaps am I not understanding your problem? I've attached a screenshot.

Pobster

lancemonotone’s picture

lancemonotone commented
StatusFileSize
new Clipboard01.jpg84.99 KB

That was a fast reply! Where did you see Make A Wish foundation? I'm not affiliated with them, but I like the work they do.

I've attached a JPG of the issue. There's a white line through the logo (sort of like The Omen, ever see that?). The line runs from top to bottom as the image loads. You're right, the issue doesn't appear in IE7, but since FF is the world's most popular browser this isn't good behavior. Is there any way to modify logo.php so that the logo doesn't display until it's fully loaded? Maybe by using an output buffer?

lancemonotone’s picture

lancemonotone commented

I think I found the answer: http://us2.php.net/manual/en/function.ob-start.php#81667.

As suggested, I placed this code at the top of logo.php and my redraw problem went away:

while (ob_get_level())
        ob_end_clean();
header("Content-Encoding: None", true);

It's an easy fix. How often does that happen?

Thanks for a great mod!

pobster’s picture

pobster commented

Ah well I work from home on the computer and all issues created get emailed directly to me. If I'm not particularly busy I'll always at least send a courtesy reply ;o)

Make-A-Wish are mentioned on this page; http://www.chchne.com/our-strategy "...charitable organizations such as Make-A-Wish and Local Heroes". Obviously my girlfriend works for the UK branch, but still! Small world! I bet there's a million charities out there!

BTW, I think you meant IE7 is the worlds most popular browser (unfortunately!) but yeah, I get what you mean - I think the problem is definitely down to css styling... When I empty my cache and reload the page I *do* see the line briefly before Firefox fully loads the image, but once FF establishes the size of the image it places it within the 'frame' and the line jumps to just above it. Without playing around with your theme files I'm not sure I can give a definitive answer as to how to fix it, but it's likely something to do with floating/ not floating your image/ setting the size of where the image is displayed correctly (rather than just letting the browser resize the frame around it). I don't actually have IE7 installed so it's going to be difficult for me to debug as obviously it's fine in Firefox!

Pobster

pobster’s picture

pobster commented

Well I've never heard of that before... Thanks for the link, I'll see if I can make it more Drupalised and commit a change when I get a moment.

Thanks!

Pobster

lancemonotone’s picture

lancemonotone commented

Just kidding about FF being the world's most popular browser. Make-a-wishful thinking. This site is just a job for me. I'm not related to the company.

Hmm, so the issue didn't appear for you? I'm using the same FF version as you and my client saw it too (not sure what browser). Anyway, problem solved. Thanks again!

pobster’s picture

pobster commented
Status: Active » Fixed

Cleaning old unclosed issues...

BTW, in case anyone is reading - I didn't commit this change as shortly after this thread I dropped logo.php completely and moved everything into hook_preprocess.

Pobster

pobster’s picture

pobster commented
Status: Fixed » Closed (fixed)