xhtml: nested block elements

Cool, thank you. You beat me to this, it was next on my list to fiddle with. I had to tweak it just a bit because it looks like it assumed a patch I didn't have (one that changed a parameter name from size to label in image_display) but after that it's working perfectly and validates.

With your patch, image_display() sometimes makes a link, sometimes it doesn't, and the condition where it does ($label = 'thumbnail') isn't immediately obvious. How about instead of adding the $tid argument, add a $link argument so it's clear you're making a link?

I don't know the trick to getting your patches accepted, but I know whining won't do it.

Looks fine to me. It gets my +1, if that means anything.

"image.module" validates to XHTML (afaics). Since version v.1.146 image.module uses a "span" around the "img", not a "div".

As for the "link" stuff: it is no longer needed (and more consistent like it is now) to put this inside 'image_display'.

I think we can "close" this. Maybe I misunderstood what you were trying to do. If so, reopen the issue.

I really don't understand what you are talking about. What this patch does is change:

<a href="..."><span class="image thumbnail"><img ... /></span></a>

into

<span class="image thumbnail"><a href="..."><img ... /></a></span>

Right?

I wrote a patch to fix xhtml validation, where block elements were put inside inline elements.

I don't see "block elements in inline elements". <span>, <a> and <img> are all inline elements. No?

thats a joke, isnt it? how do you validate your code? REOPEND

http://validator.w3.org/

I must be unknownly funny, 'coz I'm not joking... If "image.module" is not valid XHTML I will want to see it fixed - and I will bug walkah until he does fix it. I just don't see it...

you call the same function different times for the same output.

Do we? Where? What? And how does this patch change this?

not the div or span are the problem, but the links: links around links ...

What links around links? And how does changing the order of "span" and "a" help?
I know that <a> around <a> is not valid XHTML, but I don't see it being generated anywhere.

Please help me understand the issue, and I'll help you getting it applied.