Hi,

thanks for great module. RC1 looks fine apart from the fact that anonymous can use the nickname of any of the registered users. I think this should not be allowed, what do you think?

If you are aware of this or even working on this, accept my apologies and ignore/delete this issue.

Thanks,
Petiar.

CommentFileSizeAuthor
#5 guestbook.anonname.patch1 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Component: User interface » Code

How does Drupal core handle this? Patches are welcome.

petiar’s picture

petiar commented

I have no idea how Drupal core handle this, do you think it is its responsibility?

However, I'll have a look into the Guestbook code and see what can I do - it should not be complicated to implement this check.

Thanks,
Peter.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Please make sure that Comment module in Drupal core does not already implement a working solution. If it does, we'll probably fork that functionality directly from there, so any improvements to Comment module's functionality can be added to Guestbook's.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-1.0-rc1 » 6.x-1.x-dev
Category: bug » feature

Reclassifying.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new guestbook.anonname.patch1 KB

Attach patch is against CVS HEAD (6.x-2.x). Please test.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Fixed

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.