Hello, did you consider porting to 6.x? There is no ad tracking module for 6.x...

CommentFileSizeAuthor
#7 click.module.patch654 byteshutch
#2 click6.tar_.gz9.73 KBhutch

Comments

kbahey’s picture

It is not high on our list of priorities.

If someone comes up with a working patch, then we will do it soon.

If not, it will have to wait until we move our sites to Drupal 6 (which depend on views and panels, ...etc.)

hutch’s picture

StatusFileSize
new9.73 KB

I have attached a port to D6, not tested extensively but it works on my dev setup. I haven't touched the language file at all. The biggest change is in the menu system as arg() is no longer used.

Hope this helps.

kbahey’s picture

Version: master » 6.x-1.x-dev
Status: Active » Fixed

Thank you!

I made slight modifications, mainly code style, and return instead of print.

6.x tarball should be available in 24 hours.

hutch’s picture

I've just tested the 6x tarball, all is well except that the return lines on lines 143 and 176 are returning the whole page, menus, header and all. I changed them back to print statements and now it works. These lines are the same in 5x, they use print too.
As one of the modules I maintain uses 'theme('name-of-template', $content)' without print or return I tried that as well, no good I got WSOD, nothing in php.log or watchdog. I also tried 'node' instead of 'page', no good either ;-(
Quirky stuff is theming.

hutch’s picture

found a solution:
replace line 143
return theme('page', $output);
with
return $output;

and line 176
print theme('page', theme('table', $header, $rows), t('Click Thru Report'));
with
return theme('table', $header, $rows);

This gets rid of the inappropriate print statements and works as it should IMHO.

kbahey’s picture

Status: Fixed » Needs work

Yes, even though the old way would work, the new way is better. It changed in 4.7.

Check here http://drupal.org/node/22218#handling-of-return-values-from-callbacks

Can you please roll a patch for this?

hutch’s picture

StatusFileSize
new654 bytes

patch attached

kbahey’s picture

Status: Needs work » Fixed

Fixed.

Thanks again.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.