metaWeblog.newMediaObject implementation incorrect

acrollet - April 8, 2008 - 03:28
Project:Drupal
Version:7.x-dev
Component:blogapi.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Description

Hi there,

according to http://www.xmlrpc.com/metaWeblogApi, files should be uploaded in base64 encoded format. However, the blogapi module does not decode base64 files. I'm submitting this patch for review. Works for me using the python xml-rpc lib and drupal 6.1. (also tested with ecto)

AttachmentSize
blogapi.module.base64.patch479 bytes
Testbed results
blogapi.module.base64.patchfailedFailed: 8503 passes, 1 fail, 0 exceptions Detailed results

#1

meba - January 9, 2009 - 21:11
Version:6.1» 7.x-dev

Patches must be committed to HEAD first.

Simple and straightforward patch, tested and looks good. Rerolling against D7.

(Should be fixed in D5 as it's still supported. And the patch works there too.)

AttachmentSize
metaweblog_upload.patch 659 bytes

#2

meba - January 9, 2009 - 21:14

Rolling against DRUPAL-6 and DRUPAL-5 CVS.

AttachmentSize
metaweblog_upload_d6.patch 667 bytes
metaweblog_upload_d5.patch 899 bytes

#3

meba - January 9, 2009 - 21:16

I guess that the last two files might be noticed by testbot now and marked as FAILED against head so uploading D7 patch as last one again...

AttachmentSize
metaweblog_upload.patch 659 bytes
Testbed results
metaweblog_upload.patchfailedFailed: 8503 passes, 1 fail, 0 exceptions Detailed results

#4

System Message - January 9, 2009 - 22:00
Status:needs review» needs work

The last submitted patch failed testing.

 
 

Drupal is a registered trademark of Dries Buytaert.