Download & Extend

metaWeblog.newMediaObject implementation incorrect

Project:BlogAPI Improved
Version:6.x-0.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

Hi there,

according to http://www.xmlrpc.com/metaWeblogApi, files should be uploaded in base64 encoded format. However, the blogapi module does not decode base64 files. I'm submitting this patch for review. Works for me using the python xml-rpc lib and drupal 6.1. (also tested with ecto)

AttachmentSize
blogapi.module.base64.patch479 bytes

Comments

#1

Version:6.1» 7.x-dev

Patches must be committed to HEAD first.

Simple and straightforward patch, tested and looks good. Rerolling against D7.

(Should be fixed in D5 as it's still supported. And the patch works there too.)

AttachmentSize
metaweblog_upload.patch 659 bytes

#2

Rolling against DRUPAL-6 and DRUPAL-5 CVS.

AttachmentSize
metaweblog_upload_d6.patch 667 bytes
metaweblog_upload_d5.patch 899 bytes

#3

I guess that the last two files might be noticed by testbot now and marked as FAILED against head so uploading D7 patch as last one again...

AttachmentSize
metaweblog_upload.patch 659 bytes

#4

Status:needs review» needs work

The last submitted patch failed testing.

#5

Status:needs work» closed (won't fix)

Blog API is removed : #537434: Drop the blog API from core
So this won't be necessary anymore.

#6

Project:Drupal core» BlogAPI Improved
Version:7.x-dev» 6.x-0.1
Component:blogapi.module» Code
Status:closed (won't fix)» active

Moving this over to blogapi_new, since it seems that it won't get fixed in 6.x core :( - Damien, do you have any interest in applying this patch? The original patch applies and works, (with a little fuzz) I can re-roll against HEAD if you like.

nobody click here