Port to 6.x

Corrected the status since there are no patch to port, but subscribing, I would also like this one to be ported.

I could port the module but then I would like more testers for a patch I want to put into the module before I start the port work. See http://drupal.org/node/165608 with the latest version of the adjusted module attached to comment http://drupal.org/node/165608#comment-821281

wait

A D6 version would be great...

+1

Subscribing.

I have ported the module to 6.x, and would be glad to upload it. Can some one help me with how to do that? I have also emailed the original developer, Tom S., about this.

Sameer.

There should be a "File attachments" dialog within the comment form on this page. You may have to zip the file before uploading.

ok, I have attached my module files here -- but I still don't know how to enter it as a patch to drupal.org. Any clues?

My bad -- I should have uploaded a patch file, not the entire contents of my modules/compact_forms folder.

For the attached file, one way to run it is to use the -p2 parameter to patch, after you have changed location to the folder that has the compact_forms code on your Drupal installation (typically this is modules/compact_forms within the Drupal installation directory.)

So, in essence, you run:

cd drupal/modules/compact_forms
patch -p2 < patch_file.txt

Sameer.

dammit. sorry, all. i left a debug message in there, in my previous patch. please use the one attached to this comment (and also named a lot better.)

s.

I've run the patch from comment #11 (above) and it seemed to run successfully; I then activated the module, added the form css ID that I wished to modify, and saved the configuration. However, the label has not been overlaid on the form-field as indicated by the module description.

I would like to take a look to see if I can fix this. Can you send me:

1. The entries in the Configuration for which form IDs you have entered, and
2. The source (HTML) file of the page on which you are expecting the textfield title to show up inside the text field.

There are some possibilities for why this isn't working:

1. The code expects a textfield or password type for the form element in order to overlay the title. Maybe it's a different form element.
2. You need to have defined a title, which is what gets overlaid. Maybe you didn't define a title.
3. The IDs sometime don't show up as you expect --- it took me a while to figure out, for example, that it's not user-login, but user-login-block (I think) for the login/password form on the front page.

+1

Subscribing.

Works for me with the patch from post 11.

Note that the user-login-form is not the name of the form anymore in 6.x, it's just user-login. I did not change the default in the code, that might be something you want to do before you add the release.

I've attached the patched version for those who don't want to mess with running the patches.

Hm. No response from maintainer in this issue since 2008-04-08.

FYI: #404144: Taking over Compact Forms project - so either he will finally show up or I'll get this on track.

@sun: Thanks for taking this on!

(odd, but it doesn't look like #404144: Taking over Compact Forms project turned green in #16.)

#15 doesn't work for me. I get the settings form and all seems to be ok but it still doesnt make the login form "compact".

I've almost no programming experience but I'd love to help by testing if I can, this module is great.

Actually I just found out that it's just the form in the User Login Block (using the Zen theme) that doesn't "compact". If I go to /user I see that the form there works as expected. I tried switching to Garland but the User Login Block is still not compact.

Is there an issue with forms in blocks?

Good question. I cannot get the search block form (search-block-form) to compact.

*edit* After some playing around, I discovered that it does work, but using the label text i.e. Search this site, and not the submit button i.e. Search. I had to manually hide the search button using CSS and then reposition the label text a bit to get it to appear properly within the search box.

I can confirm this works with D6.10 tested with a webform form in a block.

the only thing is the text color which was illusive.

+1 !!

Incrn8: Can you explain what you mean by "some playing around"? I still cant get it to work on blocks.

The "playing around" was basically looking through the code using Firebug and finding out where the compact forms wrapper gets added. I saw that its only on the label, so make sure that your block forms have a label in their form code. If not, you won't see anything appear in your input. Oh, I also noticed that sometimes I had to click in the input field and then outside of it for the label to appear.

The module attached to post #15 is working for me. Looks good.

I agree with text color issue in #21, but for me that's minor.

Sorry, this needs to be redone, since #404132: Properly use Drupal behaviors / Code clean-up went it. Should be much more trivial now.

Attached patch should do it.

Committed with slight adjustments ;)