Closed (fixed)
Project:
Quotes
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
8 Apr 2008 at 14:35 UTC
Updated:
21 Apr 2008 at 16:57 UTC
The SQL produced by the quotes_install function has the first line:
"CREATE TABLE {quotes}..."
when it should be:
"CREATE TABLE 'drupalDbName.quotes'..."
where drupalDbName is the name of the database of the Drupal installation.
So this seems to be a parsing problem, except that oddly, the 'quotes_blocks' table is being created OK.
Comments
Comment #1
nancydruThe curly brackets are supposed to tell the database layer to insert the Drupal database name and prefix. Was there some other error message? Also, please select the correct release number so I look at the correct branch of the code.
Comment #2
nicks commentedThe SQL for building the quotes table is invalid because the keyword "UNSIGNED" is in the wrong place.
The included code is:
It should be:
Thanks for the module!
Nick
Comment #3
nancydruFix committed to -dev version.
Comment #4
vkams commentedThank you for explanation! I had made even more changes: in quotes.install file the SQL-command looks
db_query('CREATE TABLE quotes (
nid INTEGER UNSIGNED NOT NULL,
vid INTEGER UNSIGNED NOT NULL PRIMARY KEY,
author VARCHAR(255) NOT NULL,
citation VARCHAR(255),
promote INTEGER UNSIGNED NOT NULL DEFAULT 0
)
(i.e. simply word quotes without {})
Now it works!
Comment #5
nancydruThat doesn't make sense. The curly brackets tells Drupal to add the DB prefix if there is one. Removing them should NOT work.
Comment #6
nancydru