can't handle images with spaces in the filename

stella - April 8, 2008 - 15:09
Project:Fotonotes
Version:5.x-1.1-beta6
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

Hi,

First off, neat module!

However the fotonotes module doesn't appear to be able to handle images which a space in their filename. No image appears under the "edit fotonotes" tab of the image node and the following errors subsequently appear (on next page navigated too):

* warning: getimagesize(/var/www/drupal_5.7_20080212/html//files/images/Water) [function.getimagesize]: failed to open stream: No such file or directory in /var/www/drupal_5.7_20080212/html/sites/all/modules/fotonotes/fotonotes/fnclientlib/library.fnimage.inc.php on line 290.
* warning: Division by zero in /var/www/drupal_5.7_20080212/html/sites/all/modules/fotonotes/fotonotes/fnclientlib/library.fnimage.inc.php on line 293.
* warning: Division by zero in /var/www/drupal_5.7_20080212/html/sites/all/modules/fotonotes/fotonotes/fnclientlib/library.fnimage.inc.php on line 294.

The actual filename of the image in the above example is "Water lilies.jpg" (one of the Windows sample pictures actually).

See the attached screenshot for what the "edit fotonotes" page appears like in Firefox when you try to add a note.

Cheers,
Stella

AttachmentSize
fotonotes_image_space_scrnshot.JPG21.11 KB

#1

sdrycroft - May 15, 2008 - 22:52
Priority:critical» normal
Status:active» needs review

Fixed with the following patch:

http://svn.scratchpads.eu/viewvc/sites/all/modules/fotonotes/fotonotes.module?r1=335&r2=337&view=patch
http://svn.scratchpads.eu/viewvc/trunk/sites/all/modules/fotonotes/foton...

 
 

Drupal is a registered trademark of Dries Buytaert.