Collapse all children, in cascate [#244218]

Hi, I have a problem with dhtml menu 6.x-1.04 (I'm testing on localhost with Drupal 6.1). I use garland theme's tab menu for primary links, and I set the dhtml menu with "jQuery slide effect" and "Hide Siblings effect" checked. If the dhtml menu is completely closed and I click on the tab menu, once the new page is loaded the dhtml menu opens automatically the last top link that was opened (instead of staying closed)...

Also I have a question about the Hide Sibling effect. I've already seen this feature implemented and usually, once you open a top link, the previous opened link collapses totally (also its submenus collapse). Instead in dhtml menu each top link seems to keep memory of it's opened submenus (which makes it a little bit more complex to use.

Having said everything (hope it was easy to understand...), I say this module is very, very, very useful.

Comments

Comment #1

brmassa commented 9 April 2008 at 16:10

Assigned:

Unassigned

» brmassa

cippo,

thanks for reporting! im not sure i understood the first item. can you explain it again, please?

but the second one is pretty simple: i dont know how to close in cascade. Anyone that is interested on building a patch, i will be glad to analyze it.

regards,

massa

Comment #2

nofuseto commented 10 April 2008 at 08:57

Sorry brmassa, but my coding skills don't go as far as to patch your module...
Anyway, the second problem isn't that serious, you could have also decided to implement it that way ...
As for the first problem:
I use the default theme (garland), with the tab menu for primary links (so as top horizontal menu) and the navigation menu in it's default position (vertical menu to the left). While I use the navigation menu there's no problem. If I have one of the items of the navigation menu expanded and click on the tab menu the new page loads keeping the navigation menu expanded as it was in the previous page (so everything's ok). But if I collapse the navigation menu totally and then click on the tab menu, the new page shows the navigation menu expanded as it was just before I collapsed it. It seems to keep track of the last expanded state of the menu, but it doesn't remeber it's state if it is completely collapsed...
I hope this time I was clearer.
Thank you
Ciao

Comment #3

brmassa commented 21 April 2008 at 18:57

Title:

A bug (maybe) and a question on Hide Siblings effect

» Collapse all children, in cascate

Comment #4

thtas commented 6 May 2008 at 14:17

I've found this too, but only with the jQuery slide effect turned on.

Suspect it could be something to do with the how the code checks if nodes are closed or not before saving the state to the cookie. maybe when they're still animating they're not counted as display:none yet?

Comment #5

thtas commented 6 May 2008 at 15:02

okay i fixed it but not sure if i've done it the correct way.

in the switchMenu function on line 136 i made the following additions:

old

    // If the user wants the Fading effects, use it,
    // otherwise, simply make the menu disapear
    if (Drupal.settings.dhtmlMenu_useEffects) {
      $(submenu).hide('fast');
    }
    else {
      $(submenu).css('display', 'none');
    }

new

// If the user wants the Fading effects, use it,
    // otherwise, simply make the menu disapear
    if (Drupal.settings.dhtmlMenu_useEffects) {
      $(submenu).hide('fast', function () {
      	  $(submenu).css('display', 'none');
      	  Drupal.dhtmlMenu.cookieSet();
      });

    }
    else {
      $(submenu).css('display', 'none');
    }

Probably not the most elegant solution, but it will at least illustrate the problem hopefully :)