Drupal 6

I'm not currently working on any D6 projects, but have no fear, these modules will make it to D6. Probably in the next month or so. I'm also open to patches!

... and 3 months later ... :-)

Didn't even know that this module exists while I was on D5. It is incredibly useful.

Hi everyone

I will try update this module to Drupal 6... should I work from DRUPAL-5--1-16?

Cheers
Mark

Hi arthurf

I had already started on DRUPAL-5--1-16 tag, but I've checked the repository and 5--1-16 and 5 are the exact same revisions except for one file, "xspf_playlist_node.install", which had one bug fix applied #294413: variable_get errors in xspf_playlist_node .install file. See that issue for details, but I have maintained that bug fix in the Drupal 6 version.

So, here are the patches ... ;)

I have used the Coder module to guide most of the changes, and I have done both the recommended upgrades and the coding style fixes. I have also done the following:

1. Removed the function theme_xspf_playlist_info(), since it was not being used
2. Bumped the version to 2.0 since this is technically a big API change with the module being split out
3. Fixed a bug on line 107 of xspf_playlist_node.module where variable_get was called with the wrong default argument - empty string instead of empty array()
4. Fixed a bug in xspf_playlist_node_form_alter - on the admin page, if we are enabling for content types, and the upload module or cck module are not enabled, we need to display an error message to that effect. Otherwise the result is very confusing. See line 92.
5. xspf_playlist_node_thumb_get_all (line 629 of xspf_playlist_node.module) was being called with an extra parameter "TRUE", whereas it only was designed to use one parameter. So I changed it, and now the function will also return an empty array if there are no thumbs, as opposed to just returning nothing. This was resulting in error messages.
6. xspf_playlist_node_builder was passing an array as the #value of a hidden form element, which is a bug. I have imploded it to a string (line 505).
7. Put the admin form in it's own file, as per Drupal 6 convention of loading only the code required for each page
8. Implemented hook_schema() for database

Note:

1. There's still work to be done separating the modules, they all have to be enabled to work at the moment!
2. The TODO about removing xspf_playlist_alter() in xspf_playlist.module, and replacing with drupal_alter() is still outstanding.

I've made some quick tests using the upload module to upload files. I have only inspected the playlist that is created manually (i.e. I haven't actually passing it to a player).

It seems to be fine. The big errors are gone, and the playlist looks good. The thumbnail picker still doesn't work properly, but I just wanted to stop here for now and let you have a look over the patches and make sure everything is in order before trying to tackle more problems.

Let me know if the patches are ok... it won't let me upload the file xspf_playlist.admin.inc because of the extension, so I had to rename it... just change it back and it'll be fine.

Thanks again
Mark

I just applied the patch on my machine and it didn't apply cleanly, this what I got:

marking as fixed, as we're already on the 6-2 branch. please open new issues if there's anything here not actually working. thanks!