Allow CSS classes despite private download

starkos - April 9, 2008 - 14:45
Project:GeSHi Filter for syntax highlighting
Version:HEAD
Component:Administration interface
Category:feature request
Priority:normal
Assigned:soxofaan
Status:closed
Description

I would like to be able to control the coloring via my own CSS file, without having to turn on public downloads. Please enable the use of CSS classes without requiring public downloads. Right now my only recourse is to hack your module to remove the filesystem checks.

You can continue to auto-create the CSS file to the upload directory, but let me decide what to do with it.

At the very least, respect the value of the geshifilter_css_mode variable and remove the checks to "outsmart" it. Then I could manually set it myself.

Thanks!

#1

soxofaan - April 12, 2008 - 16:41
Assigned to:Anonymous» soxofaan
Status:active» patch (code needs review)

First iteration of a patch to address this issue
it adds a CSS mode option "Only add CSS classes"
(also see screenshot)

AttachmentSize
onlyaddcssclasses.png33.27 KB
244493_privateclass-d5-01.patch8.38 KB

#2

soxofaan - April 12, 2008 - 17:47

new version that adds callback that generates example css rules for the "only add css classes" option

AttachmentSize
244493_privateclass-d5-02.patch11.55 KB

#3

soxofaan - April 13, 2008 - 13:48
Version:5.x-2.6» 5.x-2.x-dev
Component:Code» Administration interface

reroll of patch for the DRUPAL-5--2 branch

AttachmentSize
244493_privateclass-d5-03.patch11.71 KB

#4

soxofaan - May 1, 2008 - 19:25

reroll

AttachmentSize
244493_privateclass-d5-04.patch12.54 KB

#5

soxofaan - May 1, 2008 - 19:41
Status:patch (code needs review)» patch (to be ported)

fixed for 5.x-2.x by http://drupal.org/cvs?commit=113955

to be ported to HEAD

#6

soxofaan - May 1, 2008 - 20:30
Version:5.x-2.x-dev» HEAD
Status:patch (to be ported)» fixed

http://drupal.org/cvs?commit=113966

#7

Anonymous (not verified) - May 15, 2008 - 20:33
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.