Filter text in results cannot be styled.

dvessel - April 9, 2008 - 23:06
Project:Bibliography Module
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Hello, this is a tiny patch so the filter labels can be styled with css. Currently, it is out in the open so there's no way to target it. A simple wrapper fixes this.

AttachmentSize
filter_results_label_wrap.patch1.08 KB

#1

dvessel - April 9, 2008 - 23:13

Ignore the first patch. Snuck in an inline style for debugging..

AttachmentSize
filter_results_label_wrap_b.patch 1.09 KB

#2

rjerome - April 14, 2008 - 18:10

This is now in the -dev code, however I changed the underscore characters in your class name to hyphens so the new class name looks like this...

class="biblio-current-filters"

Using underscores can be a problem with some browsers.

Ron.

#3

rjerome - April 14, 2008 - 18:12
Status:needs review» fixed

#4

dvessel - April 14, 2008 - 22:58

Thanks. I was going to use hyphens but all the other classes used underscores so I kept it consistent with the rest of the code.

#5

rjerome - April 15, 2008 - 00:37

Actually I also noticed that inconsistency when I was making this change. I plan to go through the code and some point soon and change all the underscores to hyphens (not that it really matters I guess, but just to be consistent and avoid upsetting any browsers).

Ron.

#6

Anonymous (not verified) - April 29, 2008 - 00:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.