Sounds like a great module. Because of that, I've cleaned-up the coding-style. No functional changes.

Comments

Crell’s picture

Status: Needs review » Needs work

There were a few failed hunks, so I think you were working against the very initial release. I've done some bug fixing since then. I committed the parts that applied. Thanks.

sun’s picture

Status: Needs work » Needs review
StatusFileSize
new2.99 KB
new9.43 KB

Re-rolled against current HEAD / DRUPAL-5.

Crell’s picture

The D5 patch fails on every hunk. :-) Probably you're not working on the latest CVS. Also, don't bother with HEAD. I virtually never use it. Drupal 5 development will happen in the DRUPAL-5 branch.

sun’s picture

Now I'm a bit confused, since I did a fresh CVS checkout of auto_username in front of creating the last patch against DRUPAL-5... are you sure?

sun’s picture

I can't help - last patch applies cleanly on a fresh CVS checkout of DRUPAL-5... maybe you've set a sticky revision/date?

Crell’s picture

Status: Needs review » Fixed

bah. The problem was my working copy was using HEAD instead of DRUPAL-5. Silly CVS. Should all be fixed and synced up now. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.