Posted by boombatower on April 10, 2008 at 2:06am
Jump to:
| Project: | SimpleTest |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed (fixed) |
Issue Summary
The user module tests didn't pass before this review for several reasons. After review the tests now passes all except for default timezone check.
<?php
$this->assertEqual($user->timezone, variable_get('date_default_timezone', NULL), t('Correct timezone field.'));
?>After a look at the code this appears to be a bug.
Other than that this test has been cleaned up quiet a bit. I removed the access rules test since that is no longer in core.
As a note UserValidationTestCase is full of unit tests. Once unit testing is implemented they should be moved.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| simpletest_review_user.patch | 17.76 KB | Ignored: Check issue status. | None | None |
Comments
#1
Was going to open an issue for access rules and you've beaten me to it!
#2
Committed.
#3
Automatically closed -- issue fixed for two weeks with no activity.