Posted by kkaefer on April 10, 2008 at 3:13pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | forms system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Currently, there are several differing naming schemes for the #process callback for RenderAPI elements (those returned from hook_elements): expand_*, form_expand_* and process_*. This patch unifies the naming to form_process_*. It does not change any functionality whatsoever.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| unify-process-callbacks.patch | 7.08 KB | Ignored: Check issue status. | None | None |
Comments
#1
I tested and code reviewed. RTBC.
#2
Excellent. This has bothered me too. Thanks, kkaefer :)
#3
#4
Can we reroll? Doesn't seem to apply.
#5
Updated. Ran some of the tests, nothing failed.
#6
Applied, grepped thru the core to verify that no traces of old functions remains. Everything looks good.
egrep -r '#process' .returns:<?phpmodules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_password_confirm'),
modules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_radios'),
modules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_checkboxes'),
modules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_weight', 'form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_date'),
modules/system/system.module: '#process' => array('form_process_ahah'),
modules/system/system.module: '#process' => array('form_process_ahah'),
?>
Neat.
#7
Nice little clean-up. I've committed this to CVS HEAD. I'm marking this 'code needs work' as it probably requires a couple of documentation updates, both in the upgrading guide as in the API docs for CVS HEAD. Please mark this closed once the documentation is in good shape. Thanks for the great work!
#8
Nice little clean-up. I've committed this to CVS HEAD. I'm marking this 'code needs work' as it probably requires a couple of documentation updates, both in the upgrading guide as in the API docs for CVS HEAD. Please mark this closed once the documentation is in good shape. Thanks for the great work!
#9
Documented at http://drupal.org/node/224333#process-functions.
#10
Automatically closed -- issue fixed for two weeks with no activity.
#11
Fixed spelling mistake from 'occured' to 'occurred' in http://drupal.org/update/modules/6/7#process_functions
#12
In the current Drupal7.0-beta2 the function "form_process_ahah" is gone. What is its replacement?
The documentation http://drupal.org/update/modules/6/7 about updateing modules still references it.
Thanks,
udo