Currently, there are several differing naming schemes for the #process callback for RenderAPI elements (those returned from hook_elements): expand_*, form_expand_* and process_*. This patch unifies the naming to form_process_*. It does not change any functionality whatsoever.

CommentFileSizeAuthor
#5 unify-process-callbacks.patch6.74 KBkkaefer
unify-process-callbacks.patch7.08 KBkkaefer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

I tested and code reviewed. RTBC.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Excellent. This has bothered me too. Thanks, kkaefer :)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Component: base system » forms system
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs work

Can we reroll? Doesn't seem to apply.

kkaefer’s picture

kkaefer CreditAttribution: kkaefer commented
Status: Needs work » Needs review
FileSize
unify-process-callbacks.patch6.74 KB

Updated. Ran some of the tests, nothing failed.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Needs review » Reviewed & tested by the community

Applied, grepped thru the core to verify that no traces of old functions remains. Everything looks good.

egrep -r '#process' . returns:

modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_password_confirm'),
modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_radios'),
modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_checkboxes'),
modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_weight', 'form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_date'),
modules/system/system.module:    '#process' => array('form_process_ahah'),
modules/system/system.module:    '#process' => array('form_process_ahah'),

Neat.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs work

Nice little clean-up. I've committed this to CVS HEAD. I'm marking this 'code needs work' as it probably requires a couple of documentation updates, both in the upgrading guide as in the API docs for CVS HEAD. Please mark this closed once the documentation is in good shape. Thanks for the great work!

Dries’s picture

Dries CreditAttribution: Dries commented

Nice little clean-up. I've committed this to CVS HEAD. I'm marking this 'code needs work' as it probably requires a couple of documentation updates, both in the upgrading guide as in the API docs for CVS HEAD. Please mark this closed once the documentation is in good shape. Thanks for the great work!

kkaefer’s picture

kkaefer CreditAttribution: kkaefer commented
Status: Needs work » Fixed

Documented at http://drupal.org/node/224333#process-functions.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

axyjo’s picture

axyjo CreditAttribution: axyjo commented

Fixed spelling mistake from 'occured' to 'occurred' in http://drupal.org/update/modules/6/7#process_functions

do’s picture

do CreditAttribution: do commented

In the current Drupal7.0-beta2 the function "form_process_ahah" is gone. What is its replacement?

The documentation http://drupal.org/update/modules/6/7 about updateing modules still references it.

Thanks,
udo