I get errors in the log after I enabled this. Was using flvplayer and xspf playlist to test flv file which worked fine.

array_merge() [function.array-merge]: Argument #2 is not an array in C:\web\apache\htdocs\home\sites\all\modules\swfobject_api\swfobject_api.module on line 92.

Invalid argument supplied for foreach() in C:\web\apache\htdocs\home\sites\all\modules\swfobject_api\swfobject_api.module on line 137.

I also got errors for flvplayer.

There was no uninstall so I'll have to do it by hand now.

Comments

sopia’s picture

sopia commented

bump!

arthurf’s picture

arthurf commented
Status: Active » Fixed

I don't think this was the fault of swfobject, but it should do a better job of not tossing errors when $params is null. I've added some fixes that should prevent this error- please see the latest version

bflora’s picture

bflora commented

Could you say what the fault is? I'm getting similar errors and I have no clue even where to begin understanding them.

a_c_m’s picture

a_c_m commented
Version: 5.x-1.2-5 » 5.x-1.2-15
Status: Fixed » Active

I get the following error on 1.2-15

    * warning: array_merge() [function.array-merge]: Argument #2 is not an array in /storage/work/projects/mediamover/site/local/public_html/sites/all/modules/swfobject_api/swfobject_api.module on line 101.
    * warning: Invalid argument supplied for foreach() in /storage/work/projects/mediamover/site/local/public_html/sites/all/modules/swfobject_api/swfobject_api.module on line 156.

Just dealing with array_merge() error first.

I added "print_r(array('base_params'=>$base_params, 'params'=>$params)); " to line 100(ie just before the merge statement), which gave : 

Array ( [base_params] => Array ( [width] => 100% [height] => 100% [no_flash] => Sorry, you need to install flash to see this content. [version] => 5 [type] => movie [bg_color] => #FFFFFF ) [params] => < )

Params is a string "> <".

Vars is a string too "> ".

Seems like there needs to be some input validation, i added 

  if(!is_array($params)) $params = array();
  if(!is_array($vars)) $vars = array();

to the top of the function, but its just a hack.

Re-opened the issue.

jhaggenburg’s picture

jhaggenburg commented

That seemed to fix it for me too, thanks!

arthurf’s picture

arthurf commented

Can you give me a debug_print_backtrace so that I can see what is calling that without an array? It just seems odd to me that that would be happening- I don't doubt you, but I'm wondering where either I messed up, or what module is giving it grief.

a_c_m’s picture

a_c_m commented

As my code is quite patched now from the stock, i've done my best to re-create the situation.

FLV media player needs to be set to use flash vars (with none set).

#0  theme_swfobject_api(<, <, <)
#1  call_user_func_array(theme_swfobject_api, Array ([0] => <,[1] => <,[2] => <)) called at [/storage/work/projects/mediamover/site/local/public_html/includes/theme.inc:170]
#2  theme(swfobject_api, <, <, <) called at [/storage/work/projects/mediamover/site/local/public_html/sites/all/modules/flvmediaplayer/flvmediaplayer.module:806]
#3  theme_flvmediaplayer_render_player(<, <, <)
#4  call_user_func_array(theme_flvmediaplayer_render_player, Array ([0] => <,[1] => <,[2] => <)) called at [/storage/work/projects/mediamover/site/local/public_html/includes/theme.inc:170]
#5  theme(flvmediaplayer_render_player, <, <, <) called at [/storage/work/projects/mediamover/site/local/public_html/sites/all/modules/flvmediaplayer/flvmediaplayer.module:732]
#6  flvmediaplayer_display(stdClass Object ([nid] => 7,[vid] => 7,[type] => video,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[sticky] => 0,[revision_timestamp] => 1210781029,[title] => Video,[body] => ,[teaser] => ,[log] => ,[format] => 1,[uid] => 1,[name] => root,[picture] => ,[data] => a:0:{},[path] => content/video,[last_comment_timestamp] => 1210781029,[last_comment_name] => ,[comment_count] => 0,[taxonomy] => Array (),[files] => Array ([29] => stdClass Object ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[description] => video.avi,[list] => 1),[30] => stdClass Object ([fid] => 30,[nid] => 7,[filename] => video.avi.flv,[filepath] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[filemime] => ,[filesize] => 158125,[vid] => 7,[description] => video.avi.flv,[list] => 0)),[media_mover] => Array ([1] => Array ([0] => Array ([mmfid] => 31,[nid] => 7,[fid] => 29,[cid] => 1,[harvest_file] => files/video.avi,[process_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[storage_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[complete_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[url] => ,[status] => 7,[date] => 1210781035,[data] => Array ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[type] => video,[title] => Video,[uid] => 1,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[moderate] => 0,[sticky] => 0,[harvest_file] => files/video.avi,[harvest_module] => mm_node,[harvest_action] => 2)))),[readmore] => ,[content] => Array ([body] => Array ([#value] => ,[#weight] => 0),[files] => Array ([#value] => <table id="attachments">

 <thead><tr><th>Attachment</th><th>Size</th> </tr></thead>
<tbody>
 <tr class="odd"><td><a href="http://localhost/projects/mediamover/site/local/public_html/files/video.avi">video.avi</a></td><td>277.25 KB</td> </tr>
</tbody></table>
,[#weight] => 50)))) called at [/storage/work/projects/mediamover/site/local/public_html/sites/all/modules/flvmediaplayer/flvmediaplayer.module:119]
#7  flvmediaplayer_nodeapi(stdClass Object ([nid] => 7,[vid] => 7,[type] => video,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[sticky] => 0,[revision_timestamp] => 1210781029,[title] => Video,[body] => ,[teaser] => ,[log] => ,[format] => 1,[uid] => 1,[name] => root,[picture] => ,[data] => a:0:{},[path] => content/video,[last_comment_timestamp] => 1210781029,[last_comment_name] => ,[comment_count] => 0,[taxonomy] => Array (),[files] => Array ([29] => stdClass Object ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[description] => video.avi,[list] => 1),[30] => stdClass Object ([fid] => 30,[nid] => 7,[filename] => video.avi.flv,[filepath] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[filemime] => ,[filesize] => 158125,[vid] => 7,[description] => video.avi.flv,[list] => 0)),[media_mover] => Array ([1] => Array ([0] => Array ([mmfid] => 31,[nid] => 7,[fid] => 29,[cid] => 1,[harvest_file] => files/video.avi,[process_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[storage_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[complete_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[url] => ,[status] => 7,[date] => 1210781035,[data] => Array ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[type] => video,[title] => Video,[uid] => 1,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[moderate] => 0,[sticky] => 0,[harvest_file] => files/video.avi,[harvest_module] => mm_node,[harvest_action] => 2)))),[readmore] => ,[content] => Array ([body] => Array ([#value] => ,[#weight] => 0),[files] => Array ([#value] => <table id="attachments">
 <thead><tr><th>Attachment</th><th>Size</th> </tr></thead>

<tbody>
 <tr class="odd"><td><a href="http://localhost/projects/mediamover/site/local/public_html/files/video.avi">video.avi</a></td><td>277.25 KB</td> </tr>
</tbody></table>
,[#weight] => 50))), view, , 1) called at [/storage/work/projects/mediamover/site/local/public_html/modules/node/node.module:479]
#8  node_invoke_nodeapi(stdClass Object ([nid] => 7,[vid] => 7,[type] => video,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[sticky] => 0,[revision_timestamp] => 1210781029,[title] => Video,[body] => ,[teaser] => ,[log] => ,[format] => 1,[uid] => 1,[name] => root,[picture] => ,[data] => a:0:{},[path] => content/video,[last_comment_timestamp] => 1210781029,[last_comment_name] => ,[comment_count] => 0,[taxonomy] => Array (),[files] => Array ([29] => stdClass Object ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[description] => video.avi,[list] => 1),[30] => stdClass Object ([fid] => 30,[nid] => 7,[filename] => video.avi.flv,[filepath] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[filemime] => ,[filesize] => 158125,[vid] => 7,[description] => video.avi.flv,[list] => 0)),[media_mover] => Array ([1] => Array ([0] => Array ([mmfid] => 31,[nid] => 7,[fid] => 29,[cid] => 1,[harvest_file] => files/video.avi,[process_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[storage_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[complete_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[url] => ,[status] => 7,[date] => 1210781035,[data] => Array ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[type] => video,[title] => Video,[uid] => 1,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[moderate] => 0,[sticky] => 0,[harvest_file] => files/video.avi,[harvest_module] => mm_node,[harvest_action] => 2)))),[readmore] => ,[content] => Array ([body] => Array ([#value] => ,[#weight] => 0),[files] => Array ([#value] => <table id="attachments">
 <thead><tr><th>Attachment</th><th>Size</th> </tr></thead>
<tbody>
 <tr class="odd"><td><a href="http://localhost/projects/mediamover/site/local/public_html/files/video.avi">video.avi</a></td><td>277.25 KB</td> </tr>

</tbody></table>
,[#weight] => 50))), view, , 1) called at [/storage/work/projects/mediamover/site/local/public_html/modules/node/node.module:770]
#9  node_build_content(stdClass Object ([nid] => 7,[vid] => 7,[type] => video,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[sticky] => 0,[revision_timestamp] => 1210781029,[title] => Video,[body] => ,[teaser] => ,[log] => ,[format] => 1,[uid] => 1,[name] => root,[picture] => ,[data] => a:0:{},[path] => content/video,[last_comment_timestamp] => 1210781029,[last_comment_name] => ,[comment_count] => 0,[taxonomy] => Array (),[files] => Array ([29] => stdClass Object ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[description] => video.avi,[list] => 1),[30] => stdClass Object ([fid] => 30,[nid] => 7,[filename] => video.avi.flv,[filepath] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[filemime] => ,[filesize] => 158125,[vid] => 7,[description] => video.avi.flv,[list] => 0)),[media_mover] => Array ([1] => Array ([0] => Array ([mmfid] => 31,[nid] => 7,[fid] => 29,[cid] => 1,[harvest_file] => files/video.avi,[process_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[storage_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[complete_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[url] => ,[status] => 7,[date] => 1210781035,[data] => Array ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[type] => video,[title] => Video,[uid] => 1,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[moderate] => 0,[sticky] => 0,[harvest_file] => files/video.avi,[harvest_module] => mm_node,[harvest_action] => 2)))),[readmore] => ,[content] => Array ([body] => Array ([#value] => ,[#weight] => 0),[files] => Array ([#value] => <table id="attachments">
 <thead><tr><th>Attachment</th><th>Size</th> </tr></thead>
<tbody>
 <tr class="odd"><td><a href="http://localhost/projects/mediamover/site/local/public_html/files/video.avi">video.avi</a></td><td>277.25 KB</td> </tr>
</tbody></table>
,[#weight] => 50))), , 1) called at [/storage/work/projects/mediamover/site/local/public_html/modules/node/node.module:689]
#10 node_view(stdClass Object ([nid] => 7,[vid] => 7,[type] => video,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[sticky] => 0,[revision_timestamp] => 1210781029,[title] => Video,[body] => ,[teaser] => ,[log] => ,[format] => 1,[uid] => 1,[name] => root,[picture] => ,[data] => a:0:{},[path] => content/video,[last_comment_timestamp] => 1210781029,[last_comment_name] => ,[comment_count] => 0,[taxonomy] => Array (),[files] => Array ([29] => stdClass Object ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[description] => video.avi,[list] => 1),[30] => stdClass Object ([fid] => 30,[nid] => 7,[filename] => video.avi.flv,[filepath] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[filemime] => ,[filesize] => 158125,[vid] => 7,[description] => video.avi.flv,[list] => 0)),[media_mover] => Array ([1] => Array ([0] => Array ([mmfid] => 31,[nid] => 7,[fid] => 29,[cid] => 1,[harvest_file] => files/video.avi,[process_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[storage_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[complete_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[url] => ,[status] => 7,[date] => 1210781035,[data] => Array ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[type] => video,[title] => Video,[uid] => 1,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[moderate] => 0,[sticky] => 0,[harvest_file] => files/video.avi,[harvest_module] => mm_node,[harvest_action] => 2)))),[readmore] => ,[content] => Array ([body] => Array ([#value] => ,[#weight] => 0),[files] => Array ([#value] => <table id="attachments">

 <thead><tr><th>Attachment</th><th>Size</th> </tr></thead>
<tbody>
 <tr class="odd"><td><a href="http://localhost/projects/mediamover/site/local/public_html/files/video.avi">video.avi</a></td><td>277.25 KB</td> </tr>
</tbody></table>
,[#weight] => 50))), , 1) called at [/storage/work/projects/mediamover/site/local/public_html/modules/node/node.module:779]
#11 node_show(stdClass Object ([nid] => 7,[vid] => 7,[type] => video,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[sticky] => 0,[revision_timestamp] => 1210781029,[title] => Video,[body] => ,[teaser] => ,[log] => ,[format] => 1,[uid] => 1,[name] => root,[picture] => ,[data] => a:0:{},[path] => content/video,[last_comment_timestamp] => 1210781029,[last_comment_name] => ,[comment_count] => 0,[taxonomy] => Array (),[files] => Array ([29] => stdClass Object ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[description] => video.avi,[list] => 1),[30] => stdClass Object ([fid] => 30,[nid] => 7,[filename] => video.avi.flv,[filepath] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[filemime] => ,[filesize] => 158125,[vid] => 7,[description] => video.avi.flv,[list] => 0)),[media_mover] => Array ([1] => Array ([0] => Array ([mmfid] => 31,[nid] => 7,[fid] => 29,[cid] => 1,[harvest_file] => files/video.avi,[process_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[storage_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[complete_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[url] => ,[status] => 7,[date] => 1210781035,[data] => Array ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[type] => video,[title] => Video,[uid] => 1,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[moderate] => 0,[sticky] => 0,[harvest_file] => files/video.avi,[harvest_module] => mm_node,[harvest_action] => 2)))),[readmore] => ,[content] => Array ([body] => Array ([#value] => ,[#weight] => 0),[files] => Array ([#value] => <table id="attachments">
 <thead><tr><th>Attachment</th><th>Size</th> </tr></thead>

<tbody>
 <tr class="odd"><td><a href="http://localhost/projects/mediamover/site/local/public_html/files/video.avi">video.avi</a></td><td>277.25 KB</td> </tr>
</tbody></table>
,[#weight] => 50))), ) called at [/storage/work/projects/mediamover/site/local/public_html/modules/node/node.module:2470]
#12 node_page_view(stdClass Object ([nid] => 7,[vid] => 7,[type] => video,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[sticky] => 0,[revision_timestamp] => 1210781029,[title] => Video,[body] => ,[teaser] => ,[log] => ,[format] => 1,[uid] => 1,[name] => root,[picture] => ,[data] => a:0:{},[path] => content/video,[last_comment_timestamp] => 1210781029,[last_comment_name] => ,[comment_count] => 0,[taxonomy] => Array (),[files] => Array ([29] => stdClass Object ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[description] => video.avi,[list] => 1),[30] => stdClass Object ([fid] => 30,[nid] => 7,[filename] => video.avi.flv,[filepath] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[filemime] => ,[filesize] => 158125,[vid] => 7,[description] => video.avi.flv,[list] => 0)),[media_mover] => Array ([1] => Array ([0] => Array ([mmfid] => 31,[nid] => 7,[fid] => 29,[cid] => 1,[harvest_file] => files/video.avi,[process_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[storage_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[complete_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[url] => ,[status] => 7,[date] => 1210781035,[data] => Array ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[type] => video,[title] => Video,[uid] => 1,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[moderate] => 0,[sticky] => 0,[harvest_file] => files/video.avi,[harvest_module] => mm_node,[harvest_action] => 2)))),[readmore] => ,[content] => Array ([body] => Array ([#value] => ,[#weight] => 0),[files] => Array ([#value] => <table id="attachments">
 <thead><tr><th>Attachment</th><th>Size</th> </tr></thead>
<tbody>
 <tr class="odd"><td><a href="http://localhost/projects/mediamover/site/local/public_html/files/video.avi">video.avi</a></td><td>277.25 KB</td> </tr>

</tbody></table>
,[#weight] => 50))))
#13 call_user_func_array(node_page_view, Array ([0] => stdClass Object ([nid] => 7,[vid] => 7,[type] => video,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[sticky] => 0,[revision_timestamp] => 1210781029,[title] => Video,[body] => ,[teaser] => ,[log] => ,[format] => 1,[uid] => 1,[name] => root,[picture] => ,[data] => a:0:{},[path] => content/video,[last_comment_timestamp] => 1210781029,[last_comment_name] => ,[comment_count] => 0,[taxonomy] => Array (),[files] => Array ([29] => stdClass Object ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[description] => video.avi,[list] => 1),[30] => stdClass Object ([fid] => 30,[nid] => 7,[filename] => video.avi.flv,[filepath] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[filemime] => ,[filesize] => 158125,[vid] => 7,[description] => video.avi.flv,[list] => 0)),[media_mover] => Array ([1] => Array ([0] => Array ([mmfid] => 31,[nid] => 7,[fid] => 29,[cid] => 1,[harvest_file] => files/video.avi,[process_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[storage_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[complete_file] => files/media_mover/ffmpeg/converted/1/video.avi.flv,[url] => ,[status] => 7,[date] => 1210781035,[data] => Array ([fid] => 29,[nid] => 7,[filename] => video.avi,[filepath] => files/video.avi,[filemime] => video/x-msvideo,[filesize] => 283906,[vid] => 7,[type] => video,[title] => Video,[uid] => 1,[status] => 1,[created] => 1210781029,[changed] => 1210781029,[comment] => 2,[promote] => 1,[moderate] => 0,[sticky] => 0,[harvest_file] => files/video.avi,[harvest_module] => mm_node,[harvest_action] => 2)))),[readmore] => ,[content] => Array ([body] => Array ([#value] => ,[#weight] => 0),[files] => Array ([#value] => <table id="attachments">
 <thead><tr><th>Attachment</th><th>Size</th> </tr></thead>
<tbody>
 <tr class="odd"><td><a href="http://localhost/projects/mediamover/site/local/public_html/files/video.avi">video.avi</a></td><td>277.25 KB</td> </tr>
</tbody></table>
,[#weight] => 50))))) called at [/storage/work/projects/mediamover/site/local/public_html/includes/menu.inc:418]
#14 menu_execute_active_handler() called at [/storage/work/projects/mediamover/site/local/public_html/index.php:15]

On further testing, it seems my patch http://drupal.org/node/258387 fixes this issue.

a_c_m