I reviewed the menu test per boombatower's matrix of outstanding items. During the review, I noticed: 1) the current test does not evaluate user permissions, 2) uses drupal api function calls to perform certain tasks instead of invoking the actions via the internal browser, and 3) has multiple test classes. I rewrote the test to eliminate these items and added more tests (number of tests increased from 130 to 309).

Issues:

1) Unlike most other modules, the menu module does not display a confirmation message for most actions. The events with messages are: delete menu item, and reset standard menu item to its default settings. Events without messages are: add custom menu, edit menu item and add menu item.

CommentFileSizeAuthor
menu.test14.39 KBsolotandem

Comments

boombatower’s picture

Status: Needs review » Fixed

Committed.

Thanks for the rewrite.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.