hook_menu uses user_access('access administration pages') for admin/settings/imagefield_gallery and admin/settings/imagefield_gallery_content_types.

I don't believe this is fine grained enough control. I want to allow a user to access administration pages, but not have access to imagefield_gallery administration pages.

Attached a patch that implements hook_perm to expose 'administer imagefield gallery' permission, and use that permission in hook_menu.

Cheers!

CommentFileSizeAuthor
imagefield_gallery_perm.patch1.64 KBbenkant

Comments

ac’s picture

ac
Primary language English
Location Perth
commented

subscribing

ac’s picture

ac
Primary language English
Location Perth
commented

Can someone please review and commit/deny. The patch works as intended.

eclipsegc’s picture

eclipsegc commented

I'll include this in the next release, there are a lot of changes coming, so for the moment, just patch as needed, I'll work this into the next revision

ac’s picture

ac
Primary language English
Location Perth
commented

Great, thanks EclipseGc

eclipsegc’s picture

eclipsegc commented
Assigned: Unassigned » eclipsegc
Status: Needs review » Fixed

This will be fixed in the next alpha for the 2.x cycle.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.