Closed (fixed)
Project:
Taxonomy Redirect
Version:
master
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
11 Apr 2008 at 15:11 UTC
Updated:
25 Sep 2008 at 00:17 UTC
Jump to comment: Most recent file
This is an excellent module; it gracefully solves a Views problem I'd been wrestling with for the last few days. Are there plans for porting it to Drupal 6 and if so, what's the timeline? I expect to be on the 5.7 branch for quite a while, at least until essential modules like Views and CCK are up and running, but I'm trying to keep tabs on the status of other modules I use relative to 6.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | taxonomy_redirect-d6.tgz | 8.52 KB | Moonshine |
| #8 | taxonomy_redirect_d6_v3.patch | 8.75 KB | Moonshine |
| #7 | taxonomy_redirect_d6_v2.patch | 8.2 KB | Moonshine |
| #4 | taxonomy_redirect_d6_v1.patch | 5.72 KB | Moonshine |
Comments
Comment #1
webchick...
Comment #2
Moonshine commentedAny update on this? Looks like the last commits were 7 months ago, so I'm not sure if this is being maintained any longer. Would the maintainers accept a patch to kick-start a D6 version?
Comment #3
nancydru@Moonshine: I've never seen a maintainer that wouldn't accept patches. It makes their life easier. It would also help others who are waiting for this.
In the meantime, you may want to read Dealing with abandoned projects.
Comment #4
Moonshine commentedInitial patch that gets things functional for Drupal 6 is attached. I also added static caching, so it only makes one DB call per vocabulary on the page. (Before it made one call per term(!))
Seems to work fine for me, others can give it a shot... :D
**Still to be done**
--> The .install file needs to be updated to use the new D6 Schema API.
Comment #5
ar-jan commentedHm, I tried your patch and the module installed fine in Drupal 6.2, but when I set up a redirect for a vocab, nothing happens. I uninstalled Taxonomy Manager just to be sure, but nothing. I didn't use it before so cannot compare it to the 5.x version.
Comment #6
Moonshine commentedWell I just patched another machine here an it's working fine for me :/
So you set up new redirect path at "/admin/build/taxonomy_redirect" and you see it saved there in the list next to the vocabulary you chose correct ?
Then when you browse to a page like "/node" where there are nodes with taxonomy terms attached (from that vocabulary you changed), what do you see for URLs? The standard system ones ? (taxonomy/term/!tid)
Comment #7
Moonshine commentedUpdated patch including schema API calls and a better disable/uninstall routines.
Comment #8
Moonshine commentedAdded hook_enable(). It's certainly ready for people to test with Drupal 6.
This module seems to be abandoned, but has value in Drupal 6. I'll accept test reports here, and will request to become maintainer here soon if the current maintainers don't appear.
Comment #9
nancydruDon't wait to start the process: http://drupal.org/node/251466
BTW, Agileware has not posted anything on DO in over 9 weeks. There have been no commits to the project on 34 weeks. Follow the process; they have two weeks to hand it over or reclaim it.
Comment #10
ar-jan commentedI tried again, you're right it works. Thanks for the work, Moonshine!
Comment: the latest patch (v3) failed at hunk #1 (both against Head and 5.x-1.1), I applied those parts manually.
Question: In what way does Taxonomy Redirect work different from using PathAuto to rewrite the url of taxonomy terms?
Comment #11
Moonshine commentedWell basically Pathauto just generates "aliases" to the paths for a vocabulary. Whereas Taxonomy Redirect actually changes the "paths" for a given vocabulary. By changing the actual "path" you can use something like Views to have a totally different type of display for different vocabularies. Pathauto would just toss pretty names on top for the urls.
Comment #12
mariagwyn commentedI would be happy to test this, but since I have failed to apply the patch (HUNK #1 failed at 1...), is a tarball upcoming?
Thanks,
Maria
Comment #13
Moonshine commentedhmm hunk #1 again.. must be something funky with the .info file in the head version I downloaded to start..
Anyways, here is a tarball if you want to try it out.
Comment #14
mariagwyn commentedInstalled the tarball, ran an experiment, seems to work very well. Yea!
I do have one request in this version if possible. On the 5.x version I was interested in the inclusion of !path as a variable. Mike Goodwin provided me with a very handy template.php function to modify this, but I think it would be a GREAT option to include in the code itself. You can see the conversation here: http://drupal.org/node/195904.
Thanks,
Maria
Comment #15
Moonshine commentedWell it's an interesting idea, but would take a lot more work then what is outlined in that thread. The problem I see with the code there (or even using !name in general) is that taxonomy names can easily have tons of characters that are not URL friendly or create problems when used directly in the URL.
People in that thread have just run into a couple random examples of hundreds of potential characters. For example "spaces", +, / , ', ", &, the entire Chinese language, etc. So I've be very reluctant adding that like it is. Actually !name itself probably needs a bunch of work in this module, when I get some time. That would be the first step, as !path would need the same handling. :/ At least Pathauto should have some code that should be useful.
Comment #16
owen barton commentedI am a commiter on this project (didn't notice this patch until just now) - thanks for working on this, the code looks great!
I just branched for DRUPAL-6 and committed the branch. I resolved 2 chunks manually and cleaned up a couple of minor code style issues. Note that when contributing patches it is best to work on cvs checkouts (see http://drupal.org/node/321), rather than tarballs downloaded from drupal.org, which add data to the .info file that causes patches to not apply :)
If someone has a chance to give the Drupal 6 1.x-dev code (which will appear as a tarball in 24 hours or so) a good workout and confirm that it is working correctly (especially enabling and disabling and interactions with forum etc) I would be happy to tag a stable release.
Also, I would suggest dropping AgileWare an e-mail - they may be happy to add you as a committer.
Comment #17
owen barton commentedComment #18
Moonshine commentedThanks for committing it. Looks like you guys found it right it time ;)
#282940: Request to take over Taxonomy Redirect project
Comment #19
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #20
mariagwyn commentedokay, where is this tarball? I am happy to test it, but I can't find it.
m
Comment #21
mariagwyn commentedComment #22
owen barton commentedI just added a release node for the 6.x dev release at http://drupal.org/node/304168 (it may be a few hours before you see the tarball ready) - please test and report back here!
Comment #23
mariagwyn commentedgot it. so far so good. I am playing a bit with it so I will report any errors. Thanks!
Comment #24
mariagwyn commentedDoes anybody know if this version included the patch here: http://drupal.org/node/188606? I am having some issues with the image gallery and redirect, still needing to make manual aliases b/c somehow the Image taxonomy is different than the breadcrumb info for Image Gallery (not a tax_redirect issue I suspect: http://drupal.org/node/304596). Just want to know what was included in this version.
thanks,
maria
Comment #25
Moonshine commentedThat's a pathauto patch, so doesn't really apply to Taxonomy Redirect code. My guess is that the image gallery module your using is not correctly asking for taxonomy paths. I've seen that in other modules. They need to be using taxonomy_term_path() to be getting at the path properly.
Comment #26
agileware commentedD6 dev release is available, please test and provide feedback. A stable version will be released soon.
Comment #27
agileware commentedComment #28
agileware commentedThe new changes for the 5.x-1.2 version will be added to the D6 version asap.
Comment #29
agileware commentedNew D6 version released, closing.