I have created POT files for all modules in contributions (DRUPAL-4-6 branch) where POT files didn't already exist.

This leads to a couple of questions:

  1. Running extractor.php on the modules can result in a number of .pot files being generated:
    • adminblock.module results in adminblock-module.pot which I guess is ready to upload
    • blogtheme.module results in general.pot which I guess should be renamed to blockmodule.pot and uploaded
    • daily.module, daily*.inc result in daily-module.pot, daily_daily-inc.pot and general.pot. Should these files be merged before uploading?
  2. Do I need to contact each module author or can I just put the POT files in CVS?
  3. Running extractor.php on the module files result in a few errors (see attached file pot_errors.txt). Should I create separate issues on each module for these errors?
CommentFileSizeAuthor
pot_errors.txt28.94 KBwulff

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Active » Fixed

1) I think it makes sense to have only one POT file per contributed module. Mergin into one file in ther fore recommended.

2) You can upload POT files into CVS without asking. If you get complaints, redirect them to me.

3) Sometimes these errors cannot be avoided, then they shoudl be ignored. Otherwise there should be bugs filed.

example:

Invalid marker content in volunteer.module:338
* t(substr($rating->comments,0,25)."...")

The comment is user contributed content. This is generally not translated and thus the t() function should be removed.

Invalid marker content in summary.module:184
* t(ucfirst($type_name)." title")

This should be rewritten to

t("%name title", array('%name' => ucfirst($type_name)))

IMNSHO ucfirst should not be used in modules.

Invalid marker content in volunteer.module:447
* t($text,$variables)

That is a plain bug. Variables shoud not be used in t().

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
kmr2005’s picture

kmr2005 commented
Anonymous’s picture

(not verified) commented
pem’s picture

pem commented
Status: Fixed » Closed (fixed)