Download & Extend
Google chart API » Issues

formatting error for xy line charts, and issue with data that is equal to 0

Posted by jhedstrom on April 11, 2008 at 6:03pm
Project:Google chart API
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The attached patch fixes:

* an issue where in ",|" was being passed in the url when using xy-line charts
* an issue where legitimate 0 values were being converted to -1. The patch checks for type null rather than a false

AttachmentSize
chart.module.patch538 bytes
Login or register to post comments

Comments

#1

Posted by tjholowaychuk on April 14, 2008 at 2:43pm
Assigned to:Anonymous» tjholowaychuk

#2

Posted by Xen on January 9, 2009 at 1:41pm

I've run into the same 0 value problem. I've fixed it by doing:

if ($v !== 'NULL'){

Instead of:

if ($v != 'NULL'){

In _chart_encode_data.

#3

Posted by sivaji on January 13, 2009 at 6:27pm

patch works

AttachmentSize
Screenshot.png 19.71 KB

#4

Posted by andyceo on September 18, 2009 at 1:27pm
Priority:normal» critical

I spend a lot of time to find why my pie diagramm is drawning incorrectly.

I have this data for diagramm (after adjusting resolution):

array(6) {
  [0]=>
  float(99)
  [1]=>
  float(24)
  [2]=>
  float(8)
  [3]=>
  float(17)
  [4]=>
  float(75)
  [5]=>
  float(0)
}

After $data['chd'] = 't:' . _chart_encode_data($chart['#data']); in function chart_build($chart) in file chart.module in line 285, I have the following encoded data:

array(1) {
  ["chd"]=>
  string(18) "t:99,24,8,17,75,-1"
}

And the diagramm looked WRONG.

After applying this patch in the file chart.module in line 384:

if ($v != 'NULL'){ --> if ($v !== 'NULL'){

Diagramm looks RIGHT.

So, please, commit this very needed patch!

AttachmentSize
chart_good.png 23.2 KB
chart_bad.png 12.91 KB

#5

Posted by andyceo on August 29, 2009 at 3:16pm
Version:5.x-1.1-1» 6.x-1.x-dev

Forget to change the version.

#6

Posted by Jeremy on September 10, 2009 at 4:14pm

Subscribe.

#7

Posted by andyceo on October 22, 2009 at 6:48pm
Assigned to:tjholowaychuk» Anonymous

Dear boombatower,

please, commit fixes for that bug!

#8

Posted by eosrei on August 16, 2011 at 8:30pm

#617194: Wrong data on chart after adjust_resolution is a dupe of this.

Additional patch located in: http://drupal.org/node/617194#comment-4859054

#9

Posted by eosrei on September 22, 2011 at 8:49pm
Status:needs review» fixed
  1. "an issue where in ",|" was being passed in the url when using xy-line charts" - Please re-open if this is still a problem
  2. "An issue where legitimate 0 values were being converted to -1." - This has been fixed in 6.x-1.x and 7.x-1.x using the patch linked in #8.

#10

Posted by System Message on October 6, 2011 at 8:51pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.