Posted by oadaeh on April 11, 2008 at 6:36pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | system.module |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
In the system_get_module_admin_tasks() function of system.module, $admin_tasks is initialized twice, first at about line 1344 and second at about line 1358. Nothing is done with the variable between the two initializations, so it's not a big deal, just unnecessary.
The attached patch eliminates the second one (and adds a blank line where it was, visually separating the two processes).
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| system_get_module_admin_tasks.patch | 611 bytes | Ignored: Check issue status. | None | None |
Comments
#1
how we use imagefield module for drupal6
#2
@drupalgeek: that's not the place to ask a question like this. Please see http://drupal.org/support
#3
Patch still applies against CVS/HEAD.
#4
#5
Here's a revised patch that moves some variable initialization around so they're grouped together and make more sense.
#6
@Dave Reid: your patch adds a line with only two spaces in it. I've attached one that fixes that.
#7
Good catch oadaeh! Patch applies cleanly, passes and RTBC.
#8
Good catch. Committed to CVS HEAD. Thanks folks!
#9
Automatically closed -- issue fixed for two weeks with no activity.