The join in location_views simply uses location.eid = node.vid. But this is not sufficient because both user and nodes have locations, and a user's uid could be the same as a node's vid. So the join needs to use location.eid=node.vid AND location.type=node.

CommentFileSizeAuthor
location_views_node.diff510 bytesDave Cohen

Comments

SeanA’s picture

SeanA commented

Aha! Thank you, this bug was driving me crazy. I have user and node locations enabled, and strange duplicate nodes were showing up in my location views. After applying the patch everything works nicely.

yesct’s picture

yesct commented
Status: Needs review » Needs work

There have been lots of improvements; I think it might be in the latest version. Could someone please confirm this in the latest version?

Please re-roll this if it is still needed.

If no-one responds in 2 weeks, I'll mark it as postponed (needs more info).

yesct’s picture

yesct commented
Status: Needs work » Postponed (maintainer needs more info)
yesct’s picture

yesct commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

3.x is out. Marking this closed since it is so old, and I think there is a different implementation now.