I was just following a complete newbie when he installed Drupal. I will skip the database-import part, it was hell :) But more important, IMO is that he could not really read the documentation in settings.php correctly. He assumed the part localhost/database in
mysql://username:password@localhost/database referred to his database directory. Since he was working on localhost, and knew nothing of the concept of a SQL server, this is not too odd.

So I chnaged this into mysql://username:password@databaseserver/databasename in the attached patch. The filled out example reamins the same, with localhost in the url (since 99% has localhost as sql server)

Note: I purposely did not user database_name, sinxce that will be confused with the prefix documentation, which uses the _ in its examples. And I hate (or well... dislike) CamelCase.

CommentFileSizeAuthor
settings_clarify.patch814 bytesBèr Kessels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bèr Kessels’s picture

Bèr Kessels CreditAttribution: Bèr Kessels commented
Version: 4.6.0 »
Bèr Kessels’s picture

Bèr Kessels CreditAttribution: Bèr Kessels commented

Patch still applies. Its a minor patch, but with some usability improvment. Please review!

breyten’s picture

breyten CreditAttribution: breyten commented
Status: Needs review » Reviewed & tested by the community

But perhaps a small message could be added that the database server is usually localhost? I think that makes it clearer why the first line says databaseserver and the second localhost.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented

I think seprarting things out into different lines might be worth considering.

This is good too.

Bèr Kessels’s picture

Bèr Kessels CreditAttribution: Bèr Kessels commented

drumm, I do not understand you comment. Waht would need to be spread out over separate lines? Are you hindting at
$database = 'drupal';
$database_suer = 'foo';

etc?

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Closed (won't fix)

The documentation says 'database name' -- how can he get confused? I don't think adding 'name' automagically solves this.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented

Yes. That is exactly what I was trying to say.

Bèr Kessels’s picture

Bèr Kessels CreditAttribution: Bèr Kessels commented

huh? No,

the files says: mysql://username:password@localhost/database

which is 1) inconsistent: averything is a "variable", but not localhost. That shouls say "databaseserver. Patch does that.
2) a bit confusing. database could be a diretory. databasename is clearer that it needs to be a databasename.