This may also be true of the default, but there's a screenshot of the blue and black on the module homepage so i KNOW this is a minor bug.

So steps are:

  • unleash drupal 6.2 out of the box. use garland theme (default).
  • install SimpleMenu dev snapshot
  • config SimpleMenu to use the blue and black theme
  • witness the black background not showing up

I think this just requires a change to simplemenu.css to work. Set #simplemenu to 'float: left' and the black background returns. See screenshot, note Firebug. That float is not there by default.

With my knowledge of floats, you may want to also make this clear both, but I haven't really tested it....

CommentFileSizeAuthor
#6 simplemenu-css.patch1.02 KBzroger
Picture 4.png176.3 KBericdfields

Comments

ericdfields’s picture

ericdfields commented

Sorry :(

The name of the css file is blackblue.css

henrrrik’s picture

henrrrik commented

The menu bar background is missing in both the original and blackblue themes. Giving #simplemenu a height of 1.8em in simplemenu.css and 2.0em in blackblue.css fixes it.

dennison’s picture

dennison commented

Had the same issue. The height: trick does it.

ardas’s picture

ardas commented

Same here.

psynaptic’s picture

psynaptic commented

Also had the same issue. Adding position: fixed to #simplemenu fixes the problem and makes the menu follow the page scroll. Seems to work nicely, at least in Firefox 3 Mac.

Edit: One problem with this is the sticky table headers get hidden under the simplemenu. Reverting to the height fix mentioned above.

zroger’s picture

zroger commented
Assigned: Unassigned » zroger
Status: Active » Needs review
StatusFileSize
new simplemenu-css.patch1.02 KB

I would prefer to use the float:left method since this is more flexible than using an em-based height.

This works for me in the browsers I have immediately available to me (FF2, FF3, Safari). If someone will verify that this works for IE6 and IE7 then i will commit this.

psynaptic’s picture

psynaptic commented
Status: Needs review » Reviewed & tested by the community

Patch works as advertised. I'd say get this committed.

psynaptic’s picture

psynaptic commented

Ok, the float: left fix works well but I just wanted to point out that display: inline-block also works. They both have different effects and different results are required on different designs so choose whichever works for your project I guess.

zroger’s picture

zroger commented
Status: Reviewed & tested by the community » Fixed

committed the float:left fix.

inline-block would be nice but browser support for it is spotty. see http://www.quirksmode.org/css/display.html

zroger’s picture

zroger commented

Follow up:

float:left fix has been reverted. instead a 'clear-block' class is now being added in the js. This fixes this problem just as well, without some other side-effects. And since the clear-block uses display: inline-block, this fix is still in line with what psynaptic mentioned.

See #http://drupal.org/node/235464#comment-1142691 for more info.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.