Closed (fixed)
Project:
Path redirect
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Apr 2008 at 21:23 UTC
Updated:
6 May 2008 at 15:12 UTC
Jump to comment: Most recent file
Comments
Comment #1
HorsePunchKid commentedGood catch. Here are patches for 5.x and 6.x. I tested in both MySQL and Postgres the upgrades from 5.x-1.1 to 5.x-1.x-dev and from 5.x-1.1 to 6.x-1.x-dev, so I'm fairly confident that they're working well.
Comment #2
HorsePunchKid commentedCommitted. Titled changed because this actually applies to 5.x independent of 6.x. Patch for 5.x above didn't include an updated
hook_install, but I fixed that and committed it. Thanks again for spotting the problem!Comment #3
junyor commentedI'm not sure the committed fix will work for existing users. For instance, what if a user upgrades to 6.x without first upgrading to the latest 5.x? And what if the user has already run update #4?
Comment #4
HorsePunchKid commentedIf a user upgrades from any 5.x release (i.e. non-dev-version) to 6.x, the 6.x installer has the same update functions that the 5.x branch has, only rewritten for the 6.x API. If a user has already run update 4 because they were running a dev version, they presumably know how to deal with that:
UPDATE {system} SET schema_version = 3 WHERE name = 'path_redirect'Then run update.php, and you'll get the necessary updates. As far as I understand, upgrading from dev versions is not something that needs to be explicitly supported. That said, since we've had this dev version sitting around for quite some time, it might make sense to add another update function; I'm just not (yet) convinced it's necessary.
I have some more patches to port to 6.x before releasing it, anyway, and I'll make sure to test the upgrade paths before I do.
Comment #5
junyor commentedGot it. I'll run the update manually.
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.