Review: BlogAPI Module Test

boombatower - April 12, 2008 - 22:36
Project:SimpleTest
Component:Code
Category:task
Priority:normal
Assigned:boombatower
Status:closed
Description

The test didn't pass due to database prefixing issues and privilege changes. The combination of the two proved hard to debug and required a change to xmlrpc.inc which is included in a separate patch.

The test now passes with one exception.

Unexpected PHP error [Undefined property: stdClass::$is_date] severity [E_NOTICE] in [~/includes/xmlrpc.inc line 70]

AttachmentSize
simpletest_review_blogapi.patch3.95 KB
simpletest_review_blogapi_xmlrpc.patch1.29 KB

#1

boombatower - April 12, 2008 - 22:38

Fixed a few t()s that were missing and made a small cleanup change.

AttachmentSize
simpletest_review_blogapi.patch 7.75 KB

#2

boombatower - April 12, 2008 - 22:38
Status:needs review» fixed

Committed.

#3

boombatower - April 12, 2008 - 22:39

As a note the exception is thrown when the following line (currently 81) is executed.

<?php
$result
= xmlrpc($local, 'metaWeblog.newMediaObject', $blog_id, $web_user->name, $web_user->pass_raw, $file);
?>

#4

Anonymous (not verified) - April 26, 2008 - 22:42
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.