Request for text after image support
rconstantine - April 13, 2008 - 00:22
| Project: | Openads |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
changing this line of code in openads.js from this
az+="src='"+m3_u+"?zoneid="+z+"&cb="+m3_r;
to this
az+="src='"+m3_u+"?zoneid="+z+"&withtext=1&cb="+m3_r;
allows us to use the 'text after image' feature.
In testing, it looks as if it doesn't mess anything up for images without text after it. If you don't know what I'm talking about, let me know and I can point you to the right admin page in openx.
#1
#2
that's a nice feature...I hadn't noticed that before.
Added this to CVS for Javascript, Local and XML-RPC methods. There is
no toggle for text below image for Remote method so I guess that is
not supported in OpenX.
#3
FYI, it looks like plain text is fine, but links get somewhat butchered depending on what kind they are. This is just a note that you might want to add to the README. I think that absolute links work but relative (i.e. those internal to Drupal that Drupal usually changes into full Drupal paths) do not. For example, I think if for the text you put something like
<a href="node">Some text here</a>then Drupal changes the link into http://www.yoursite.com/"node" with the quotes in place.At least, I think that's what it did. I'm not in front of it right now. This is a difficult thing to test because I think the ads, including the after-text, are cached by OpenX. I'm sure there is a setting for how long to wait before refreshing cached ads, but I couldn't find it. Setting it to zero might allow real-time testing.
Ideally, one would be able to put a link using text such as "Advertise with us" which is were a visitor could inquire about rates and terms. Also, FYI, Drupal doesn't handle mailto links, so those are out of the question I think. So such a link would need to point to a contact page or something.
If anyone figures this out, please post your solution.
#4
Drupal is doing nothing to the Text below image text set in OpenX. Openads module
does nothing more than build the HTML/Javascript that OpenX uses for invoking ads.
There's no way to capture the incoming OpenX text below image text and rewrite it
nor do I think that's really within the scope of the module.
This is what's in the OpenX manual about Text below image links:
Seems to me that the destination of the link automatically created by the Text below image
is the destination link of the banner ad itself. So you should set the URL you want in
the banner's destination field.
#5
Automatically closed -- issue fixed for two weeks with no activity.