Hello,

When configuring emfield, the iFilm provider is not displayed correctly in the checkable list of supported providers. This is due to the fact that the file is called contrib/video_cck/providers/ifilm.inc but the functions inside are all named video_cck_spike_*.

Suggested solution:

  1. rename ifilm.inc to spike.inc

    2. OR

  2. rename all the functions in ifilm.inc to video_cck_ifilm_*

Note that a blind search & replace is not necessarily what you want in case of 2) because the correct url of the video service seems to be http://www.spike.com/

Please note this issue applies to 5.x-1.x at the time of my writing.
Cheers

Comments

alex ua’s picture

alex ua commented
Status: Active » Closed (fixed)

This has already been fixed in the Dev version. We'll roll the next release today or tomorrow, so that should help to stop the confusion.

jonathan_hunt’s picture

jonathan_hunt commented
Version: 5.x-1.0 » 5.x-1.2
Priority: Minor » Critical
Status: Closed (fixed) » Active

I've reopened this as I just updated Emfield from 5.x-1.0 to 5.x-1.2 and I got a fatal error since the functions inside ifilm.inc are duplicates of spike.inc

Fatal error: Cannot redeclare video_cck_spike_info() (previously declared in /home/www/web15/web/drupal5/sites/rivers/modules/emfield/contrib/video_cck/providers/ifilm.inc:7) in /home/www/web15/web/drupal5/sites/rivers/modules/emfield/contrib/video_cck/providers/spike.inc on line 20

grep -rn 'video_cck_spike_info' modules/
modules/emfield/contrib/video_cck/providers/spike.inc:6:function video_cck_spike_info() {
modules/emfield/contrib/video_cck/providers/ifilm.inc:6:function video_cck_spike_info() {

jonathan_hunt’s picture

jonathan_hunt commented
Status: Active » Closed (fixed)

Apologies. I updated using subversion and it merged the set of provider files. I see ifilm.inc isn't in the 5.x-1.2 release.