Module persistent_login.module contains a closing "?>" PHP tag. It also includes unwanted white space after the closing tag, in the form of a newline. Other versions seem to have this too.

Advice at http://drupal.org/coding-standards ("PHP Code Tags") recommends removing closing PHP tags.

(Maybe not really worth a patch? But here's one anyway.)

Best wishes, Mark.

CommentFileSizeAuthor
persistent_login.module.HEAD-a-closetag.patch505 bytesplumbley

Comments

markus_petrux’s picture

markus_petrux commented

This change is also required by persistent_login_debug.inc and persistent_login.install

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Active

fixed in all php files in D5. leaving open for HEAD

bjaspan’s picture

bjaspan commented
Status: Active » Fixed

Fixed in HEAD. Thanks markus_petrux and Moshe!

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.