zen.css breaks .container-inline
jjeff - April 13, 2008 - 14:51
| Project: | Zen |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
There's a declaration in zen.css that says:
.form-item label /* The label for a form element */
{
display: block;
font-weight: bold;
}I'm not sure of it's purpose, but it breaks the .content-inline declaration from system.css (which looks like this):
/*
** Inline items (need to override above)
*/
.container-inline div, .container-inline label {
display: inline;
}The declaration in zen.css takes precedence and form labels don't show up inline. I'm not sure whether it's better to just remove the display: block; from that line or to add a separate declaration after it to allow for inline stuff. Taking the "more is more" philosophy, I've created a patch that adds another declaration to zen.css.
If the purpose of the top rule can be determined, then we should probably keep it in and apply this patch. Otherwise, maybe we can just delete that rule from zen.css and call it a day.
| Attachment | Size |
|---|---|
| zen-label-inline.patch | 556 bytes |
#1
Ok, I committed to HEAD and DRUPAL-5.
BTW, I don't see any forms that get broken in Core, but no core modules have a label in their inline forms. I'm assuming this breakage in a contrib module.
#2
Automatically closed -- issue fixed for two weeks with no activity.