Closed (fixed)
Project:
FCKeditor - WYSIWYG HTML editor
Version:
6.x-1.2-1
Component:
Code
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Apr 2008 at 16:12 UTC
Updated:
16 Sep 2009 at 06:06 UTC
Jump to comment: Most recent file
Comments
Comment #1
Jorrit commentedAfter disabling and reenabling it seems to work again. I don't know what went wrong here, if you can find it, it would be great, otherwise ignore it.
Comment #2
wwalc commentedI can't reproduce this... feel free to reopen this ticket if you can provide a step-by-step instruction to reproduce this issue.
Comment #3
Jorrit commentedThe problem has also appeared on another site, and it appears to have to do with
$Config['QuickUploadAbsolutePath']['Image']not being set atio.phpin functionGetResourceTypeDirectory. This causesapache_lookup_uri()to be called inServer_MapPath, and that function returns some voodoo that doesn't work.The reason that
$Config['QuickUploadAbsolutePath']['Image']is not set is that$Config['UserFilesAbsolutePath']is not set and the fact that I changed the config such that$Config['QuickUploadAbsolutePath']['Image']= $Config['UserFilesAbsolutePath'], because I do not like those file type based subdirectories.$Config['UserFilesAbsolutePath']is not set is that$fck_user_files_pathis not set, which relates to$_SESSION['FCKeditor']['UserFilesAbsolutePath']not being set. This is caused by$_SESSION['FCKeditor']['UserFilesAbsolutePath']not being set infckeditor_process_textarea()infckeditor.modulebecause IMCE is turned on.In the IMCE specific code of FCKeditor I do not see a reference to the quick upload functionality, so I really wonder if IMCE is involved in quick uploads or not? Is it something I've done wrong? Is it an FCKeditor module bug?
[edit]
Perhaps it is usefull if I mention that my config.php in the php connector still contains the line
require_once "../../../../../filemanager.config.php";and$Config['UserFilesAbsolutePath'] = '' ;just above it.Comment #4
wwalc commentedI think that $cookie_domain in sites/.../settings.php may be the answer. Did you uncomment it?
Comment #5
Jorrit commentedYes. That works fine. The things I described above were for the situation in which I had modified the connector config with the include, as is required for non-imce integration. In this case, I left it out, to see what happens. Now I simply get a popup saying that the file uploader is disabled. I can see why:
When IMCE is enabled, Config['LinkUploadURL'] and Config['FlashUploadURL'] are never set. Those values are required for the quick upload forms, and are set when imce is false and $basic_uploads is true. According to the code, IMCE is only used as a replacement of the file browser, not as a replacement of the quick upload functionality. The FCKeditor profile settings should be used for that.
In my opinion the following should be done:
- The settings for quick upload (called basic upload in the admin) should be available all the time, including the directory settings
- Using a drop down the file browser type should be selected, either false, builtin or imce (if available)
I will attach a patch that illustrates my ideas. Don't consider this a full patch: it changes some configuration values so the .install file would also have to be adapted. But it gives an idea what I mean. I think this is much more clear to the end user.
By the way, I see some instances of
function_exists('imce_menu')to check for module existence. Why aren't you using module_exists?Comment #6
Jorrit commentedThe following patch is an updated version and includes a patch for fckeditor.install such that the settings are preserved.
Comment #7
Jorrit commentedComment #8
wwalc commentedThis patch looks good.
The only that I would like you to change as well is the information that is shown below "File browser settings": because basic and advanced file management is gone, we need there a short introduction to "File browser type" and "quick uploads".
As we discussed via email earlier, please feel free to apply for the CVS account - I'll make you a co-maintainer of the FCKeditor module then and we'll start working together on the new version in the 6--2 branch.
Comment #9
Jorrit commentedThis patch improves the documentation.
Comment #10
AjK commentedFyi, CVS account application approved.
Comment #11
wwalc commentedComment #12
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #13
kassissieh commentedDoes IMCE + FCKEditor support the private file storage method for quick upload? I have it working nicely where IMCE respects the site's private file storage option when using the Browse Server button. It would be a major usability improvement to invoke IMCE for Quick Upload as well, because most of users will prefer that simple file upload method to the file browser. Thank you for your feedback to this question.
Comment #14
OnkelTem commentedDoes anybody know - WHAT is Quick Upload? No info here, in readme.txt, on (f)CKEditor website, on Help Pages, on Configuration page.
Thanks.