This was a show-stopper for the actions-triggers test case. Chx's new browser doesn't seem to handle sub-selects properly (e.g. with <optgroup>) properly.

Comments

boombatower’s picture

We talked about this in IRC and I will take a look at it shortly, if time allows.

boombatower’s picture

Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new2.01 KB

This patch appears to fix the issue of options nested inside of optgroup tag.

However, it doesn't appear to fix the issues you were having with the trigger test and the database. You should probably open a separate issue for that.

boombatower’s picture

Status: Needs review » Fixed

Committed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

pwolanin’s picture

Project: SimpleTest » Drupal core
Version: » 7.x-dev
Component: Code » simpletest.module
Assigned: boombatower » pwolanin
Status: Closed (fixed) » Active

This fix may not have made it into core.

pwolanin’s picture

Status: Active » Needs review
StatusFileSize
new843 bytes

I came across this while trying to write this test: http://drupal.org/node/276583

A version of the patch above is in Drupal HEAD, but it doesn't seem to work correctly. Seems we need another level of looping to actually find all the options in the optgroup.

moshe weitzman’s picture

Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

Peter's patch indeed fixes the test at #276583: TestingParty08: Tests for admin/user/user filters. This is holding up other tests from the Test party, so I mark it critical. Lets quickly fix bugs in core simpletest. Kinda demotivates/confuses test authors.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.