Simpletest-light doesn't handle selects with <optgroup>'s correctly

cwgordon7 - April 14, 2008 - 00:45
Project:Drupal
Version:7.x-dev
Component:simpletest.module
Category:bug report
Priority:critical
Assigned:pwolanin
Status:closed
Description

This was a show-stopper for the actions-triggers test case. Chx's new browser doesn't seem to handle sub-selects properly (e.g. with <optgroup>) properly.

#1

boombatower - April 14, 2008 - 01:04

We talked about this in IRC and I will take a look at it shortly, if time allows.

#2

boombatower - April 14, 2008 - 04:16
Assigned to:Anonymous» boombatower
Status:active» needs review

This patch appears to fix the issue of options nested inside of optgroup tag.

However, it doesn't appear to fix the issues you were having with the trigger test and the database. You should probably open a separate issue for that.

AttachmentSize
simpletest_nested_options.patch 2.01 KB

#3

boombatower - April 14, 2008 - 21:03
Status:needs review» fixed

Committed.

#4

Anonymous (not verified) - April 28, 2008 - 21:04
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#5

pwolanin - August 28, 2008 - 08:54
Project:SimpleTest» Drupal
Version:7.x-1.x-dev» 7.x-dev
Component:Code» simpletest.module
Assigned to:boombatower» pwolanin
Status:closed» active

This fix may not have made it into core.

#6

pwolanin - August 28, 2008 - 09:37
Status:active» needs review

I came across this while trying to write this test: http://drupal.org/node/276583

A version of the patch above is in Drupal HEAD, but it doesn't seem to work correctly. Seems we need another level of looping to actually find all the options in the optgroup.

AttachmentSize
optgroup-fix-246261-5.patch 843 bytes

#7

moshe weitzman - August 29, 2008 - 00:04
Priority:normal» critical
Status:needs review» reviewed & tested by the community

Peter's patch indeed fixes the test at #276583: TestingParty08: Tests for admin/user/user filters. This is holding up other tests from the Test party, so I mark it critical. Lets quickly fix bugs in core simpletest. Kinda demotivates/confuses test authors.

#8

Dries - August 30, 2008 - 09:28
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#9

Anonymous (not verified) - September 13, 2008 - 09:32
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.