for now, should I use #translatable 5.x-1.3 or 5.x-dev version?

and I have noticed some different between #translatable and localizer(5.x-3.3) in taxonomy.module.

as attachment, major two place different, Should I add/change that?

1. function taxonomy_overview_terms($vid) {
#about line 212 [#translatable|taxonomy.module]

--------------------------------------------------
foreach ($tree as $term) {

$total_entries++; // we're counting all-totals, not displayed
if (($start_from && ($start_from * $page_increment) >= $total_entries) || ($displayed_count == $page_increment)) {
continue;
}
// Translatable support.
if (function_exists('tobject')) {
$term = tobject('taxonomy_term', $term->tid, $term);
}
--------------------------------------------------

==>
[localizer|taxonomy.module]

--------------------------------------------------
foreach ($tree as $term) {
if(function_exists('to')) $term=to('taxonomy_term', $term->tid, $term);
$total_entries++; // we're counting all-totals, not displayed
if (($start_from && ($start_from * $page_increment) >= $total_entries) || ($displayed_count == $page_increment)) {
continue;
}
--------------------------------------------------

2. function taxonomy_form_alter($form_id, &$form) {
#about line 723 [#translatable|taxonomy.module]

--------------------------------------------------
while ($vocabulary = db_fetch_object($c)) {
if ($vocabulary->tags) {
--------------------------------------------------

==>
[localizer|taxonomy.module]

--------------------------------------------------
while ($vocabulary = db_fetch_object($c)) {
if(function_exists('to')) $vocabulary = to('taxonomy_vocabulary', $vocabulary->vid, $vocabulary);
if ($vocabulary->tags) {
--------------------------------------------------

3. function taxonomy_get_term($tid) {
#about line 1226 [#translatable|taxonomy.module]

--------------------------------------------------
if (!isset($terms[$tid])) {
$terms[$tid] = db_fetch_object(db_query('SELECT * FROM {term_data} WHERE tid = %d', $tid));
}
--------------------------------------------------

==>
[localizer|taxonomy.module]

--------------------------------------------------
if (!isset($terms[$tid])) {
$terms[$tid] = db_fetch_object(db_query('SELECT * FROM {term_data} WHERE tid = %d', $tid));
if (function_exists('to')) $terms[$tid] = to('taxonomy_term', $tid, $terms[$tid]);
}
--------------------------------------------------

CommentFileSizeAuthor
#2 Report.zip7.34 KByelban
#2 translatable.gif19.26 KByelban
3.GIF14.75 KByelban
2.GIF13.79 KByelban
1.GIF29.9 KByelban

Comments

sun’s picture

Title: Should I use 5.x-1.3 or 5.x-dev? and does need to patch (follow localizer 5.x-3.3)? » Patch differences between Localizer and Translatable
Category: support » task

Yes, you need to apply Translatable's patch on Drupal core for multilingual support.
You should use 5.x-1.3, but don't enable Localizer modules concurrently or you'll receive an unrecoverable fatal PHP error.

Your outlined differences between Localizer and Translatable patches need analysis. Thanks for taking the time to highlight them.

yelban’s picture

Title: Patch differences between Localizer and Translatable » report for differences between Localizer and Translatable
StatusFileSize
new19.26 KB
new7.34 KB

as title, attachment Report.zip is the fully report for taxonomy.module differences between Localizer and Translatable,

best regards, Yelban

sun’s picture

Title: report for differences between Localizer and Translatable » Patch differences between Localizer and Translatable

Never attach compressed archives to issues on drupal.org, please. And please do not change the title because it changes the title of the whole issue (not just your follow-up).

sun’s picture

Status: Active » Fixed

I think the current patches are okay. If they were not, certain features would not work.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.