The module names are labels for the checkboxes that they relate to on the admin/build/modules page, but not on the admin/build/modules/uninstall page.

This creates a somewhat inconsistent interface that lacks a useful feature.

The patch included is quite simple and fixes the missing label issue.

CommentFileSizeAuthor
#4 modules_uninstall_label.patch904 bytessenpai
#1 modules_uninstall_label.patch946 bytesboombatower
modules_uninstall_label.patch940 bytesboombatower

Comments

boombatower’s picture

boombatower commented
StatusFileSize
new modules_uninstall_label.patch946 bytes

Updated for dot coding standard change.

senpai’s picture

senpai commented
Title: Add label to unistall module name to match install list » Add label to uninstall module-name to match install list

Changing the title due to spelling error.

boombatower’s picture

boombatower commented

@Senpai: Hehe...typo...thanks.

Any comments...really simple patch...not a lot to discuss. Hoping for a yeh or neh and commit.

senpai’s picture

senpai commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new modules_uninstall_label.patch904 bytes

Tested on D7 HEAD, and working as intended. RTBC this baby! I like the idea, and consistency in HTML output is always a good thing.

One thing though. Never submit a patch for core that includes the Eclipse commenting at the top. It won't apply for anyone else unless they've used the same name for their core installation. Patch re-rolled.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Good catch. How did you spot that?

Committed to CVS HEAD. Thanks.

boombatower’s picture

boombatower commented

I was enabling and un-installing a module to test the install hook and noticed that clicking on the text didn't work. Having a bug in the install hook of the module I was messing with turned out to find an unrelated bug. :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.