I've been using both DrupalvB 5.x-1.0 and 5.x-1.1 on a development project for the past couple of months. I wanted to offer a few comments so you can determine if these are bugs or potentially if I'm not following the intent of the code. Here are my thoughts:

  • Function drupalvb_user_update in drupalvb.module: this function works as expected if a user just updates his name, email or password. However if a user updates his username, there seems to be an issue. In both _drupalvb_update_vb_user and _drupalvb_create_vb_user, the code keys off of username, rather than nid. Once a user changes his username, the connection between Drupal and vBulletin is broken and there is no way to re-establish it. Wouldn't it be more appropriate to (1) pass the new username to the functions in drupalvb.inc.php and (2) key the WHERE clause off of nid rather than username? This is how I have edited the code and now seems to be able to accept username changes where it could not before.
  • Second comment on drupalvb_user_update function: I could be misunderstanding your intent, but isn't the call to the _drupalvb_create_vb_user function in the ELSE statement wrong? The code references if (_drupalvb_create_vb_user($useredit->name, ..., but there is no $useredit. I searched the entire code looking for $useredit and none to be found. Should this not be $edit_user->name instead?
  • Function drupalvb_private_messages in drupalvb.module: Once again I could be wrong here, but it seems like there is an issue with the PM function. I can enable the Forum Info block with no problem. However when I click the "private messages" link in the block, I get all types of errors. First it starts out by saying Table 'forum.system' doesn't exist query: SELECT * FROM system WHERE type = 'theme' in /web/includes/database.mysql.inc on line 172 when trying to build the drupalvb/pms page. Because of this comment, my guess is the code does not point us back to the Drupal database once the drupalvb.module processing is complete. The reason I would think this is the reference to "forum.system". vBulletin does not have a system table, but Drupal sure does. Prior to building the drupalvb/pms page we were running the drupalvb code pointing at the vBulletin database "forum", so my guess is the problem is in there. After this I receive about 20 warning messages all saying the same basic thing: user warning: Table 'forum.locales_source' doesn't exist query: SELECT s.lid, t.translation FROM locales_source s INNER JOIN locales_target t ON s.lid = t.lid WHERE s.source = 'From' AND t.locale = 'en-US-local' in /web/includes/database.mysql.inc on line 172. Once again, we're trying to pull things from Drupal but we're pointed to the vBulletin database.

I'm hoping this information is useful and please let me know your thoughts. Thanks.

Comments

sgdev’s picture

sgdev commented

Also just a few other pieces of information ...

I'm using $db_prefix = ''; since we don't have prefixes on our DB.
Able to create a new user and have them show up in vBulletin.
Able to log in to Drupal with said user and have them logged in to vBulletin.

Running on the following:

  • Drupal 5.7
  • PHP 5.2.3
  • Apache 2.2.8
  • MySQL 5.0.45
  • WAMP setup
  • vBulletin 3.6.9
  • DrupalvB 5.x-1.1 (previously was using 1.0)
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Closed (won't fix)

Sorry, I don't get what's the actual bug report in here. Please file separate issues for separate bugs. Please also consider providing patches for the proposed changes in your original post. However, please bear in mind that drupalvb is undergoing major changes within the next weeks.

sgdev’s picture

sgdev commented

You don't get what actual bug report? I don't think I could have given you more details:

  1. If a user changes their user name, the link to vBulletin breaks because the SQL queries are designed improperly.
  2. There is an incorrect reference in the code to $useredit when it should be $edit_user->name.
  3. When clicking private messages in the block, there are all types of error messages because the code references the vBulletin database when it should reference the Drupal database.

Clear enough? If you want three separate bug reports I will do so. Are you saying you won't fix this because drupalvb is being changed?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Thanks for clarifying. I think that issue 1. already exists in the queue (please follow-up there), and 2. as well as 3. is already fixed in 5.x-2.x now. I have re-written the whole module in the past days. A development snapshot should be available within the next 12 hours.

sgdev’s picture

sgdev commented
Status: Closed (won't fix) » Closed (fixed)

I don't readily see anything in the queue for #1, so I will post a note about it. As for #2 and #3, look forward to seeing 5.x-2.x in the near future. I will post a message about #2 in case anyone needs the fix for 1.x. Thanks for your efforts.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Closed (fixed) » Closed (won't fix)

Re: 2. and 3.: See http://drupal.org/node/249914

sgdev’s picture

sgdev commented

Thanks. Any thoughts on when you are expecting to have 2.x production-ready? We are about to launch a new site and trying to decide if we should just stick with 5.x-1.1 for now.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

From my own testing, the code is pretty stable, but may be not complete yet. A RC1 will probably follow this or next week, and 2.0 hopefully right afterwards. I would like to release it soon, however, it depends on you and other users to test what's there. My plan is to fix most of the remaining open bug reports in the queue for 2.0, and those issues/patches will need review and tests, too.