For example, http:///node/10/revisions/view/24/25 will always produce an Access Denied message. The Diff module itself seems to install just fine, with no other related errors I can find.

I'm running a nearly fresh install of Drupal 6.2, but let me know if you'd like more detailed information.

This may not be a problem with the program; perhaps something needs to be added to the documentation?

CommentFileSizeAuthor
#14 diff-d6-menu-access.patch1.12 KBdamien tournoud
#11 diff.module.diff58 bytesAnonymous (not verified)

Comments

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Postponed (maintainer needs more info)

check your permissions.

stretchsje’s picture

stretchsje commented

If you're referring to the privileges in drupal, I'm logged in as the administrator there. Shouldn't I automatically have the permissions needed? In any event, I see no checkbox to grant diff permissions to authenticated users.

Server-side, I granted read and execute privileges to DiffEngine.php.

Thanks

dleins’s picture

dleins commented
Category: task » bug

I have exactly the same problem. Fresh install of 6.2, permissions look to be fine. I'm logged in as administrator and get an Access Denied message when trying to access revision diff report. Tried entering several different revision combinations, created an authenticated user with permissions to everything listed in permissions, logged in as that user and still no go.

rötzi’s picture

rötzi commented

There was a change to the menu API in Drupal 6.2 (http://drupal.org/node/243389).
We may have to specify the access argument in "diff_menu" for it to work correctly.

Bundus’s picture

Bundus commented

I to have a fresh copy of Drupal 6.2 and get the dreaded "Access denied: You are not authorized to access this page." message when attempting to compare any two revisions regardless of user account (administrator or otherwise)

janv@www.drupalsites.net’s picture

janv@www.drupalsites.net commented

Same problem here

janv@www.drupalsites.net’s picture

janv@www.drupalsites.net commented

I added

'access arguments' => array('view revisions'),

to diff_menu and the problem is solved.

jared.lenover’s picture

jared.lenover commented

I'm still having problems with this. I added janv's line to the diff_menu function in diff.module but I still get access denied when I press the Show diff button. Am I maybe adding the code in the wrong spot?

janv@www.drupalsites.net’s picture

janv@www.drupalsites.net commented

I had to clear the cache at admin/settings/performance to make it work.

jared.lenover’s picture

jared.lenover commented

Thanks! That worked. I appreciate the help. :)

Anonymous’s picture

Anonymous (not verified) commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new diff.module.diff58 bytes

I have the same problem. Please add the correspondng code for access arguments to the diff_menu function and publish a new release candidate.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Priority: Normal » Critical
Status: Needs review » Reviewed & tested by the community

The patch style is not to the Drupal standard, but the concept is valid and this is trivial enough that patch style shouldn't hold back the fix. IMHO, this is a "critical" bug since it completely breaks the module.

Anonymous’s picture

Anonymous (not verified) commented

I appreciate for the wrong format. I was too lucky, that I created a patch on windows, as applying patches is very difficult and creating one was very easy (using winmerge).
I'll check the Drupal standard.

Hope that get's in the module soon.

damien tournoud’s picture

damien tournoud commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new diff-d6-menu-access.patch1.12 KB

Here is a correct patch that solve this issue (+ an E_ALL problem with some forms, especially views one).

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

committed. release forthcoming. thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.